[LargeIconService] Allow overriding request URL by a field trial param

[LargeIconService] Allow overriding request URL by a field trial param

This CL integrates last minute comments from product on the first
experiment with fetch favicons on demand - for "Articles for you" on the
New Tab Page.

This CL further allows to override to request URL format using a field
trial parameter so that operating that experiment is more flexible.

BUG=705572
Review-Url: https://codereview.chromium.org/2839653002
Cr-Commit-Position: refs/heads/master@{#467051}
Committed: https://chromium.googlesource.com/chromium/src/+/99b05cd8620a446c0e84fefbf28e8db907b44bdc

[jkrcal, 2017-04-24 14:55:18]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 14:55:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkrcal, 2017-04-24 14:55:46]

jkrcal@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[jkrcal, 2017-04-24 14:55:46]

Peter, could you PTAL?

(This is a merge candidate for M59.)

[pkotwicz, 2017-04-24 15:12:37]

https://codereview.chromium.org/2839653002/diff/1/components/favicon/core/lar...
File components/favicon/core/large_icon_service.cc (right):

https://codereview.chromium.org/2839653002/diff/1/components/favicon/core/lar...
components/favicon/core/large_icon_service.cc:329: DLOG(WARNING) << "favicon "
<< server_request_url;
Why the logging?

[commit-bot: I haz the power, 2017-04-24 16:10:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 16:10:03]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2017-04-24 17:32:11]

Thanks, PTAL again.

https://codereview.chromium.org/2839653002/diff/1/components/favicon/core/lar...
File components/favicon/core/large_icon_service.cc (right):

https://codereview.chromium.org/2839653002/diff/1/components/favicon/core/lar...
components/favicon/core/large_icon_service.cc:329: DLOG(WARNING) << "favicon "
<< server_request_url;
On 2017/04/24 15:12:36, pkotwicz wrote:
> Why the logging?

Oh, I am sorry. This is an omission :) Removed.

[pkotwicz, 2017-04-24 20:31:02]

LGTM!

[jkrcal, 2017-04-25 17:25:19]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2017-04-25 17:25:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/2839653002/#ps40001
(title: "Fix the code for a unit-test")

[commit-bot: I haz the power, 2017-04-25 17:25:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 18:27:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493141119247840,
"parent_rev": "96c9b34ea924ed4300f90839cab36adf4f8eaecc", "commit_rev":
"99b05cd8620a446c0e84fefbf28e8db907b44bdc"}

[commit-bot: I haz the power, 2017-04-25 18:27:29]

Description was changed from

==========
[LargeIconService] Allow overriding request URL by a field trial param

This CL integrates last minute comments from product on the first
experiment with fetch favicons on demand - for "Articles for you" on the
New Tab Page.

This CL further allows to override to request URL format using a field
trial parameter so that operating that experiment is more flexible.

BUG=705572
==========

to

==========
[LargeIconService] Allow overriding request URL by a field trial param

This CL integrates last minute comments from product on the first
experiment with fetch favicons on demand - for "Articles for you" on the
New Tab Page.

This CL further allows to override to request URL format using a field
trial parameter so that operating that experiment is more flexible.

BUG=705572

Review-Url: https://codereview.chromium.org/2839653002
Cr-Commit-Position: refs/heads/master@{#467051}
Committed:
https://chromium.googlesource.com/chromium/src/+/99b05cd8620a446c0e84fefbf28e...
==========

[commit-bot: I haz the power, 2017-04-25 18:27:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/99b05cd8620a446c0e84fefbf28e...