Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: components/favicon/core/large_icon_service_unittest.cc

Issue 2849813002: [LargeIconService] Allow overriding request URL by a field trial param (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/large_icon_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/large_icon_service_unittest.cc
diff --git a/components/favicon/core/large_icon_service_unittest.cc b/components/favicon/core/large_icon_service_unittest.cc
index d5cabcb48fac46d8a79b418371093f98c841e627..ef463077010f4f6faedb63727ee92df29a1b0c5b 100644
--- a/components/favicon/core/large_icon_service_unittest.cc
+++ b/components/favicon/core/large_icon_service_unittest.cc
@@ -139,7 +139,7 @@ class LargeIconServiceTest : public testing::Test {
TEST_F(LargeIconServiceTest, ShouldGetFromGoogleServer) {
const GURL kExpectedServerUrl(
"https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
- "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE,URL"
+ "&size=32&min_size=42&max_size=64&fallback_opts=TYPE,SIZE,URL"
"&url=http://www.example.com/");
EXPECT_CALL(mock_favicon_service_, UnableToDownloadFavicon(_)).Times(0);
@@ -167,7 +167,7 @@ TEST_F(LargeIconServiceTest, ShouldGetFromGoogleServer) {
TEST_F(LargeIconServiceTest, ShouldGetFromGoogleServerWithOriginalUrl) {
const GURL kExpectedServerUrl(
"https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
- "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE,URL"
+ "&size=32&min_size=42&max_size=64&fallback_opts=TYPE,SIZE,URL"
"&url=http://www.example.com/");
const GURL kExpectedOriginalUrl("http://www.example.com/favicon.png");
@@ -197,7 +197,7 @@ TEST_F(LargeIconServiceTest, ShouldTrimQueryParametersForGoogleServer) {
const GURL kDummyUrlWithQuery("http://www.example.com?foo=1");
const GURL kExpectedServerUrl(
"https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
- "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE,URL"
+ "&size=32&min_size=42&max_size=64&fallback_opts=TYPE,SIZE,URL"
"&url=http://www.example.com/");
EXPECT_CALL(*mock_image_fetcher_,
@@ -239,7 +239,7 @@ TEST_F(LargeIconServiceTest, ShouldReportUnavailableIfFetchFromServerFails) {
const GURL kDummyUrlWithQuery("http://www.example.com?foo=1");
const GURL kExpectedServerUrl(
"https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
- "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE,URL"
+ "&size=32&min_size=42&max_size=64&fallback_opts=TYPE,SIZE,URL"
"&url=http://www.example.com/");
EXPECT_CALL(mock_favicon_service_, SetLastResortFavicons(_, _, _, _, _))
@@ -268,7 +268,7 @@ TEST_F(LargeIconServiceTest, ShouldNotGetFromGoogleServerIfUnavailable) {
mock_favicon_service_,
WasUnableToDownloadFavicon(GURL(
"https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
- "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE,URL"
+ "&size=32&min_size=42&max_size=64&fallback_opts=TYPE,SIZE,URL"
"&url=http://www.example.com/")))
.WillByDefault(Return(true));
« no previous file with comments | « components/favicon/core/large_icon_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698