Move all Page Info strings into page_info_strings.grdp

Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES (crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY (crbug.com/716296)

BUG=663975, 709701, 716296, 716296, 716305
TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org

Review-Url: https://codereview.chromium.org/2849713003
Cr-Commit-Position: refs/heads/master@{#469190}
Committed: https://chromium.googlesource.com/chromium/src/+/fc1d5e5df6ef53ecc87135178352b22665296c3a

[lgarron, 2017-04-28 02:45:13]

Description was changed from

==========
Move all Page Info strings into page_info_strings.grdp

This CL only does the following:
- Move strings into page_info_strings.grdp
- Remove old "chrome/grit/generated_resources.h" includes where possible.

All the remaining work has been documented using blockers for crbug.com/663975

BUG=663975
==========

to

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.

All the remaining work has been documented using blockers for crbug.com/663975

BUG=663975
==========

[lgarron, 2017-04-28 02:45:35]

lgarron@chromium.org changed reviewers:
+ estark@chromium.org

[lgarron, 2017-04-28 02:45:36]

estark@, could you review?

[lgarron, 2017-04-28 02:45:42]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 02:46:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-04-28 02:58:31]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 02:58:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 03:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:27:08]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[estark, 2017-04-28 05:05:25]

lgtm with a couple questions and red bots

https://codereview.chromium.org/2849713003/diff/20001/chrome/browser/ui/page_...
File chrome/browser/ui/page_info/page_info.cc (right):

https://codereview.chromium.org/2849713003/diff/20001/chrome/browser/ui/page_...
chrome/browser/ui/page_info/page_info.cc:48: #include
"chrome/grit/generated_resources.h"
is this still needed?

https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
File components/page_info_strings.grdp (right):

https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
components/page_info_strings.grdp:24: <!-- Internal page summary strings -->
Should any of these be marked "not is_ios" so they aren't bundled with iOS
builds?

[lgarron, 2017-04-28 22:04:32]

https://codereview.chromium.org/2849713003/diff/20001/chrome/browser/ui/page_...
File chrome/browser/ui/page_info/page_info.cc (right):

https://codereview.chromium.org/2849713003/diff/20001/chrome/browser/ui/page_...
chrome/browser/ui/page_info/page_info.cc:48: #include
"chrome/grit/generated_resources.h"
On 2017/04/28 at 05:05:25, estark wrote:
> is this still needed?

Nope, as long as we move IDS_CERT_POLICY_PROVIDED_CERT_MESSAGE (which this CL
does).
Removed!

https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
File components/page_info_strings.grdp (right):

https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
components/page_info_strings.grdp:24: <!-- Internal page summary strings -->
On 2017/04/28 at 05:05:25, estark wrote:
> Should any of these be marked "not is_ios" so they aren't bundled with iOS
builds?

Perhaps, but let me get some expert advice. It seems all the component string
files are included at once in e.g. page_info.cc, and most don't include guards
for strings against iOS.

[lgarron, 2017-04-28 22:16:15]

lgarron@chromium.org changed reviewers:
+ tfarina@chromium.org

[lgarron, 2017-04-28 22:16:15]

tfarina@, could you advise on how to handle segments of strings that are
currently not used on iOS?
(If not, could you recommend someone who can?)

[lgarron, 2017-04-28 23:10:55]

Description was changed from

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.

All the remaining work has been documented using blockers for crbug.com/663975

BUG=663975
==========

to

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.

All the remaining work has been documented using blockers for crbug.com/663975

BUG=663975
==========

[tfarina, 2017-04-29 17:53:12]

https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
File components/page_info_strings.grdp (right):

https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
components/page_info_strings.grdp:24: <!-- Internal page summary strings -->
On 2017/04/28 22:04:32, lgarron wrote:
> On 2017/04/28 at 05:05:25, estark wrote:
> > Should any of these be marked "not is_ios" so they aren't bundled with iOS
> builds?
> 
> Perhaps, but let me get some expert advice. It seems all the component string
> files are included at once in e.g. page_info.cc, and most don't include guards
> for strings against iOS.

Do you need to exclude these strings from iOS here? If yes, there is a way.

[lgarron, 2017-05-01 18:48:48]

On 2017/04/29 at 17:53:12, tfarina wrote:
>
https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
> File components/page_info_strings.grdp (right):
> 
>
https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
> components/page_info_strings.grdp:24: <!-- Internal page summary strings -->
> On 2017/04/28 22:04:32, lgarron wrote:
> > On 2017/04/28 at 05:05:25, estark wrote:
> > > Should any of these be marked "not is_ios" so they aren't bundled with iOS
> > builds?
> > 
> > Perhaps, but let me get some expert advice. It seems all the component
string
> > files are included at once in e.g. page_info.cc, and most don't include
guards
> > for strings against iOS.
> 
> Do you need to exclude these strings from iOS here? If yes, there is a way.

Yep, I can copy other examples for that.

Do we *need* to do it explicitly in order to avoid bloating the iOS binary?
(Other components don't seem to be as diligent about it, so maybe there's some
resource shaking I'm not aware of.)

[tfarina, 2017-05-01 20:03:39]

Description was changed from

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.

All the remaining work has been documented using blockers for crbug.com/663975

BUG=663975
==========

to

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.

All the remaining work has been documented using blockers for crbug.com/663975

BUG=663975
==========

[tfarina, 2017-05-01 20:03:39]

tfarina@chromium.org changed reviewers:
+ sdefresne@chromium.org

[tfarina, 2017-05-01 20:04:09]

On 2017/05/01 18:48:48, lgarron wrote:
> On 2017/04/29 at 17:53:12, tfarina wrote:
> >
>
https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
> > File components/page_info_strings.grdp (right):
> > 
> >
>
https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
> > components/page_info_strings.grdp:24: <!-- Internal page summary strings -->
> > On 2017/04/28 22:04:32, lgarron wrote:
> > > On 2017/04/28 at 05:05:25, estark wrote:
> > > > Should any of these be marked "not is_ios" so they aren't bundled with
iOS
> > > builds?
> > > 
> > > Perhaps, but let me get some expert advice. It seems all the component
> string
> > > files are included at once in e.g. page_info.cc, and most don't include
> guards
> > > for strings against iOS.
> > 
> > Do you need to exclude these strings from iOS here? If yes, there is a way.
> 
> Yep, I can copy other examples for that.
> 
> Do we *need* to do it explicitly in order to avoid bloating the iOS binary?
> (Other components don't seem to be as diligent about it, so maybe there's some
> resource shaking I'm not aware of.)

I think Sylvain can answer that better than me.

[sdefresne, 2017-05-02 12:56:36]

On 2017/05/01 20:04:09, tfarina wrote:
> On 2017/05/01 18:48:48, lgarron wrote:
> > On 2017/04/29 at 17:53:12, tfarina wrote:
> > >
> >
>
https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
> > > File components/page_info_strings.grdp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2849713003/diff/20001/components/page_info_st...
> > > components/page_info_strings.grdp:24: <!-- Internal page summary strings
-->
> > > On 2017/04/28 22:04:32, lgarron wrote:
> > > > On 2017/04/28 at 05:05:25, estark wrote:
> > > > > Should any of these be marked "not is_ios" so they aren't bundled with
> iOS
> > > > builds?
> > > > 
> > > > Perhaps, but let me get some expert advice. It seems all the component
> > string
> > > > files are included at once in e.g. page_info.cc, and most don't include
> > guards
> > > > for strings against iOS.
> > > 
> > > Do you need to exclude these strings from iOS here? If yes, there is a
way.
> > 
> > Yep, I can copy other examples for that.
> > 
> > Do we *need* to do it explicitly in order to avoid bloating the iOS binary?
> > (Other components don't seem to be as diligent about it, so maybe there's
some
> > resource shaking I'm not aware of.)
> 
> I think Sylvain can answer that better than me.

There is no automatic unused resources pruning on iOS, so if we want to avoid
the resources from increasing the size of the iOS binary, we have to manually
exclude them.

The reason that most of the components don't exclude resources on iOS is that
they were componentized to be shared with iOS and thus the resources were also
used there. I guess that since then, more components have been added and
localised strings too that are not necessary on iOS.

Localised strings takes roughly 3Mb on iOS for a total of 60Mb for the full
application (according to the OS), so roughly 5%. I guess that it could make
sense to exclude strings that are not used on iOS (as it would make sense to
exclude those not used on Android too) if there are a lot of them.

[lgarron, 2017-05-03 00:20:49]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 00:21:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 00:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 00:37:16]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lgarron, 2017-05-03 01:54:31]

Description was changed from

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.

All the remaining work has been documented using blockers for crbug.com/663975

BUG=663975
==========

to

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)

BUG=663975, 709701, 716296, 716305
==========

[lgarron, 2017-05-03 02:07:43]

lgarron@chromium.org changed reviewers:
+ mthiesse@chromium.org
- sdefresne@chromium.org, tfarina@chromium.org

[lgarron, 2017-05-03 02:07:43]

mthiesse@, could you review the WebVR header include change?

estark@: I don't have all week to babysit the trybots on seperate CLs, so I've
folded the dependent CLs into this. You've already LGTMed them, but I thought
I'd mention it.
- https://crrev.com/2849563003 Rename remaining IDS_PAGEINFO_* strings to
IDS_PAGE_INFO_*
Owner	
- https://crrev.com/2844393003 Remove dead Page Info permission strings and
associated code.
- https://crrev.com/2847863004 Unify semantically duplicated Page Info string
(cookies, unencrypted basic auth).
  - Note: This one requires two external reviewers for the basic auth string, so
I've left out just that part form here.

[lgarron, 2017-05-03 02:24:06]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 02:24:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mthiesse, 2017-05-03 02:27:43]

lgtm

https://codereview.chromium.org/2849713003/diff/100001/chrome/browser/android...
File
chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc
(right):

https://codereview.chromium.org/2849713003/diff/100001/chrome/browser/android...
chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc:8:
#include "components/strings/grit/components_strings.h"
I think you need to make the same change to
insecure_content_transient_texture.cc in this same directory.

[commit-bot: I haz the power, 2017-05-03 02:34:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 02:34:30]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lgarron, 2017-05-03 03:04:13]

Description was changed from

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)

BUG=663975, 709701, 716296, 716305
==========

to

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

BUG=663975, 709701, 716296, 716296, 716305
==========

[lgarron, 2017-05-03 03:06:07]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 03:06:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 03:16:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 03:16:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[lgarron, 2017-05-03 22:02:28]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 22:03:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-05-03 22:07:29]

The CQ bit was unchecked by lgarron@chromium.org

[lgarron, 2017-05-03 22:07:50]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 22:08:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-05-03 22:57:01]

Description was changed from

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

BUG=663975, 709701, 716296, 716296, 716305
==========

to

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

BUG=663975, 709701, 716296, 716296, 716305
TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org
==========

[commit-bot: I haz the power, 2017-05-03 23:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 23:05:52]

Dry run: This issue passed the CQ dry run.

[lgarron, 2017-05-03 23:08:26]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-05-03 23:08:27]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org,
mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2849713003/#ps160001
(title: "Fix moar.")

[lgarron, 2017-05-03 23:09:04]

Description was changed from

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

BUG=663975, 709701, 716296, 716296, 716305
TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org
==========

to

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY
(crbug.com/704788)

BUG=663975, 709701, 716296, 716296, 716305
TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org
==========

[commit-bot: I haz the power, 2017-05-03 23:09:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 23:15:25]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1493852906989220,
"parent_rev": "dc545e9fc108b42ff88ae4d696ea4b5ed3bffcc1", "commit_rev":
"fc1d5e5df6ef53ecc87135178352b22665296c3a"}

[commit-bot: I haz the power, 2017-05-03 23:15:40]

Description was changed from

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

BUG=663975, 709701, 716296, 716296, 716305
TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org
==========

to

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

BUG=663975, 709701, 716296, 716296, 716305
TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org

Review-Url: https://codereview.chromium.org/2849713003
Cr-Commit-Position: refs/heads/master@{#469190}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc1d5e5df6ef53ecc87135178352...
==========

[commit-bot: I haz the power, 2017-05-03 23:15:45]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/fc1d5e5df6ef53ecc87135178352...

[lgarron, 2017-05-03 23:22:55]

Description was changed from

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

BUG=663975, 709701, 716296, 716296, 716305
TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org

Review-Url: https://codereview.chromium.org/2849713003
Cr-Commit-Position: refs/heads/master@{#469190}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc1d5e5df6ef53ecc87135178352...
==========

to

==========
Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order
and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where
possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES
(crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY
(crbug.com/716296)

BUG=663975, 709701, 716296, 716296, 716305
TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org

Review-Url: https://codereview.chromium.org/2849713003
Cr-Commit-Position: refs/heads/master@{#469190}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc1d5e5df6ef53ecc87135178352...
==========