Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: chrome/browser/ui/login/login_handler.cc

Issue 2849713003: Move all Page Info strings into page_info_strings.grdp (Closed)
Patch Set: Fix moar. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/login/login_handler.h" 5 #include "chrome/browser/ui/login/login_handler.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 } else { 510 } else {
511 *authority = l10n_util::GetStringFUTF16( 511 *authority = l10n_util::GetStringFUTF16(
512 IDS_LOGIN_DIALOG_AUTHORITY, 512 IDS_LOGIN_DIALOG_AUTHORITY,
513 url_formatter::FormatUrlForSecurityDisplay(request_url)); 513 url_formatter::FormatUrlForSecurityDisplay(request_url));
514 authority_url = request_url; 514 authority_url = request_url;
515 } 515 }
516 516
517 if (!content::IsOriginSecure(authority_url)) { 517 if (!content::IsOriginSecure(authority_url)) {
518 // TODO(asanka): The string should be different for proxies and servers. 518 // TODO(asanka): The string should be different for proxies and servers.
519 // http://crbug.com/620756 519 // http://crbug.com/620756
520 *explanation = 520 *explanation = l10n_util::GetStringUTF16(IDS_PAGE_INFO_NOT_SECURE_SUMMARY);
521 l10n_util::GetStringUTF16(IDS_PAGE_INFO_NON_SECURE_TRANSPORT);
522 } else { 521 } else {
523 explanation->clear(); 522 explanation->clear();
524 } 523 }
525 } 524 }
526 525
527 // static 526 // static
528 void LoginHandler::ShowLoginPrompt(const GURL& request_url, 527 void LoginHandler::ShowLoginPrompt(const GURL& request_url,
529 net::AuthChallengeInfo* auth_info, 528 net::AuthChallengeInfo* auth_info,
530 LoginHandler* handler) { 529 LoginHandler* handler) {
531 DCHECK_CURRENTLY_ON(BrowserThread::UI); 530 DCHECK_CURRENTLY_ON(BrowserThread::UI);
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 bool is_main_frame = 660 bool is_main_frame =
662 (request->load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) != 0; 661 (request->load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) != 0;
663 LoginHandler* handler = LoginHandler::Create(auth_info, request); 662 LoginHandler* handler = LoginHandler::Create(auth_info, request);
664 BrowserThread::PostTask( 663 BrowserThread::PostTask(
665 BrowserThread::UI, FROM_HERE, 664 BrowserThread::UI, FROM_HERE,
666 base::BindOnce(&LoginHandler::LoginDialogCallback, request->url(), 665 base::BindOnce(&LoginHandler::LoginDialogCallback, request->url(),
667 base::RetainedRef(auth_info), base::RetainedRef(handler), 666 base::RetainedRef(auth_info), base::RetainedRef(handler),
668 is_main_frame)); 667 is_main_frame));
669 return handler; 668 return handler;
670 } 669 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm ('k') | chrome/browser/ui/login/login_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698