chrome/browser/ui/android/page_info/connection_info_popup_android.cc - Issue 2849713003: Move all Page Info strings into page_info_strings.grdp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/page_info/connection_info_popup_android.cc

Issue 2849713003: Move all Page Info strings into page_info_strings.grdp (Closed)

Patch Set: Fix moar. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc ('k') | chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/page_info/connection_info_popup_android.cc

diff --git a/chrome/browser/ui/android/page_info/connection_info_popup_android.cc b/chrome/browser/ui/android/page_info/connection_info_popup_android.cc

index d31fbb58962c0f08d2988910ca2b6d3e5ed34f06..b36826f66e35410d685cadb0fe7f4e7ecb5d314d 100644

--- a/chrome/browser/ui/android/page_info/connection_info_popup_android.cc

+++ b/chrome/browser/ui/android/page_info/connection_info_popup_android.cc

@@ -111,7 +111,7 @@ void ConnectionInfoPopupAndroid::SetIdentityInfo(

if (identity_info.identity_status !=

PageInfo::SITE_IDENTITY_STATUS_NO_CERT) {

certificate_label =

- l10n_util::GetStringUTF16(IDS_PAGEINFO_CERT_INFO_BUTTON);

+ l10n_util::GetStringUTF16(IDS_PAGE_INFO_CERT_INFO_BUTTON);

}

Java_ConnectionInfoPopup_addCertificateSection(

@@ -120,7 +120,7 @@ void ConnectionInfoPopupAndroid::SetIdentityInfo(

if (identity_info.show_ssl_decision_revoke_button) {

base::string16 reset_button_label = l10n_util::GetStringUTF16(

- IDS_PAGEINFO_RESET_INVALID_CERTIFICATE_DECISIONS_BUTTON);

+ IDS_PAGE_INFO_RESET_INVALID_CERTIFICATE_DECISIONS_BUTTON);

Java_ConnectionInfoPopup_addResetCertDecisionsButton(

env, popup_jobject_,

ConvertUTF16ToJavaString(env, reset_button_label));