Get rid of base::SharedMemory::NULLHandle();

Get rid of base::SharedMemory::NULLHandle();

This CL is a refactor and has no intended behavior change.

NullHandle() has two use cases:
  * Create an invalid handle.
  * Return an object that can be compared against a handle to check validity.
The former is also the behavior of the default constructor of
base::SharedMemoryHandle, and the latter should be done with the member
IsValid().

Fixing the latter also allows the removal of operator== and operator!=.

BUG=713763
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849633002
Cr-Commit-Position: refs/heads/master@{#468231}
Committed: https://chromium.googlesource.com/chromium/src/+/a40775d038de9a6a75db3965104abe56b77c9ed6

[erikchen, 2017-04-27 19:33:49]

Description was changed from

==========
Get rid of base::SharedMemory::NULLHandle();

This CL is a refactor and has no intended behavior change.

NullHandle() has two use cases:
  * Create an invalid handle.
  * Return an object that can be compared against a handle to check validity.
The former is also the behavior of the default constructor of
base::SharedMemoryHandle, and the latter should be done with the member
IsValid().

Fixing the latter also allows the removal of operator== and operator!=.

BUG=713763
==========

to

==========
Get rid of base::SharedMemory::NULLHandle();

This CL is a refactor and has no intended behavior change.

NullHandle() has two use cases:
  * Create an invalid handle.
  * Return an object that can be compared against a handle to check validity.
The former is also the behavior of the default constructor of
base::SharedMemoryHandle, and the latter should be done with the member
IsValid().

Fixing the latter also allows the removal of operator== and operator!=.

BUG=713763
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2017-04-27 19:36:38]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2017-04-27 19:36:56]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2017-04-27 19:36:57]

thakis: Please review.

[commit-bot: I haz the power, 2017-04-27 19:37:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 19:51:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:51:52]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Nico, 2017-04-27 19:54:30]

lgtm, nice.

https://codereview.chromium.org/2849633002/diff/1/ui/surface/transport_dib.h
File ui/surface/transport_dib.h (right):

https://codereview.chromium.org/2849633002/diff/1/ui/surface/transport_dib.h#...
ui/surface/transport_dib.h:39: static Handle DefaultHandleValue() { return
base::SharedMemoryHandle(); }
Guess this can go too.

[erikchen, 2017-04-27 21:23:14]

erikchen@chromium.org changed reviewers:
+ brettw@chromium.org

[erikchen, 2017-04-27 21:23:14]

brettw: Please stamp this refactor. thakis is an OWNER of base/  and has
reviewed the whole CL.

[erikchen, 2017-04-27 21:26:49]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:27:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2017-04-27 21:30:44]

lgtm

[commit-bot: I haz the power, 2017-04-27 21:41:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 21:41:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2017-04-28 01:45:11]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 01:46:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 02:24:50]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[erikchen, 2017-04-28 17:56:00]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 17:56:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 20:28:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 20:28:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2017-04-28 20:52:15]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 20:52:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 21:59:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:59:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2017-04-28 22:05:14]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 22:06:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2017-04-28 23:25:55]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 23:26:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 00:46:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 00:46:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2017-04-29 05:18:55]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2017-04-29 05:18:56]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2849633002/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-04-29 05:19:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 07:15:52]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1493443135964170,
"parent_rev": "e7a3d6480969e0a0ef64fa44f7bcae57f312b04e", "commit_rev":
"a40775d038de9a6a75db3965104abe56b77c9ed6"}

[commit-bot: I haz the power, 2017-04-29 07:17:13]

Description was changed from

==========
Get rid of base::SharedMemory::NULLHandle();

This CL is a refactor and has no intended behavior change.

NullHandle() has two use cases:
  * Create an invalid handle.
  * Return an object that can be compared against a handle to check validity.
The former is also the behavior of the default constructor of
base::SharedMemoryHandle, and the latter should be done with the member
IsValid().

Fixing the latter also allows the removal of operator== and operator!=.

BUG=713763
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Get rid of base::SharedMemory::NULLHandle();

This CL is a refactor and has no intended behavior change.

NullHandle() has two use cases:
  * Create an invalid handle.
  * Return an object that can be compared against a handle to check validity.
The former is also the behavior of the default constructor of
base::SharedMemoryHandle, and the latter should be done with the member
IsValid().

Fixing the latter also allows the removal of operator== and operator!=.

BUG=713763
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849633002
Cr-Commit-Position: refs/heads/master@{#468231}
Committed:
https://chromium.googlesource.com/chromium/src/+/a40775d038de9a6a75db3965104a...
==========

[commit-bot: I haz the power, 2017-04-29 07:17:15]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/a40775d038de9a6a75db3965104a...