Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: base/memory/shared_memory.h

Issue 2849633002: Get rid of base::SharedMemory::NULLHandle(); (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/memory/shared_memory_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/shared_memory.h
diff --git a/base/memory/shared_memory.h b/base/memory/shared_memory.h
index d3daa80717432d6ec40ec1841f7a73ff7f0f1569..34cdc1ed16273befbaa8258f01777b95af33efaf 100644
--- a/base/memory/shared_memory.h
+++ b/base/memory/shared_memory.h
@@ -92,17 +92,15 @@ class BASE_EXPORT SharedMemory {
// invalid value; NULL for a HANDLE and -1 for a file descriptor)
static bool IsHandleValid(const SharedMemoryHandle& handle);
- // Returns invalid handle (see comment above for exact definition).
- static SharedMemoryHandle NULLHandle();
-
// Closes a shared memory handle.
static void CloseHandle(const SharedMemoryHandle& handle);
// Returns the maximum number of handles that can be open at once per process.
static size_t GetHandleLimit();
- // Duplicates The underlying OS primitive. Returns NULLHandle() on failure.
- // The caller is responsible for destroying the duplicated OS primitive.
+ // Duplicates The underlying OS primitive. Returns an invalid handle on
+ // failure. The caller is responsible for destroying the duplicated OS
+ // primitive.
static SharedMemoryHandle DuplicateHandle(const SharedMemoryHandle& handle);
#if defined(OS_POSIX)
« no previous file with comments | « no previous file | base/memory/shared_memory_handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698