media/capture/content/thread_safe_capture_oracle.cc - Issue 2849633002: Get rid of base::SharedMemory::NULLHandle();

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/content/thread_safe_capture_oracle.cc

Issue 2849633002: Get rid of base::SharedMemory::NULLHandle(); (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/content/thread_safe_capture_oracle.cc

diff --git a/media/capture/content/thread_safe_capture_oracle.cc b/media/capture/content/thread_safe_capture_oracle.cc

index 6824067612930461385c02d791a841c9679775d4..0f817d14ab661385d26a60344030b6126b6ddba2 100644

--- a/media/capture/content/thread_safe_capture_oracle.cc

+++ b/media/capture/content/thread_safe_capture_oracle.cc

@@ -141,7 +141,7 @@ bool ThreadSafeCaptureOracle::ObserveEventAndDecideCapture(

*storage = VideoFrame::WrapExternalSharedMemory(

params_.requested_format.pixel_format, coded_size,

gfx::Rect(visible_size), visible_size, output_buffer_access->data(),

- output_buffer_access->mapped_size(), base::SharedMemory::NULLHandle(), 0u,

+ output_buffer_access->mapped_size(), base::SharedMemoryHandle(), 0u,

base::TimeDelta());

// If creating the VideoFrame wrapper failed, call DidCaptureFrame() with

// !success to execute the required post-capture steps (tracing, notification

« no previous file with comments | « media/base/video_frame.cc ('k') | mojo/edk/embedder/embedder.h » ('j') | no next file with comments »