Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 2849533003: [ObjC ARC] Converts components/autofill/ios/browser:browser to ARC. (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, ios-reviews_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts components/autofill/ios/browser:browser to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2849533003 Cr-Commit-Position: refs/heads/master@{#468677} Committed: https://chromium.googlesource.com/chromium/src/+/5815c61aa07c697f16cd03a9affb47952314e000

Patch Set 1 #

Patch Set 2 : Address comments #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M components/autofill/ios/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/ios/browser/autofill_driver_ios.h View 1 1 chunk +1 line, -1 line 2 comments Download
M components/autofill/ios/browser/autofill_driver_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/ios/browser/credit_card_util.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M components/autofill/ios/browser/form_suggestion.mm View 1 4 chunks +8 lines, -13 lines 1 comment Download
M components/autofill/ios/browser/js_autofill_manager.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/ios/browser/js_suggestion_manager.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/ios/browser/personal_data_manager_observer_bridge.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/ios/browser/personal_data_manager_observer_bridge.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
gambard
PTAL, this is https://codereview.chromium.org/2807173003 with the comments addressed.
3 years, 7 months ago (2017-04-27 15:49:22 UTC) #4
stkhapugin
lgtm
3 years, 7 months ago (2017-05-02 12:30:35 UTC) #5
gambard
+sdefresne: PTAL.
3 years, 7 months ago (2017-05-02 12:31:18 UTC) #7
sdefresne
lgtm https://codereview.chromium.org/2849533003/diff/20001/components/autofill/ios/browser/autofill_driver_ios.h File components/autofill/ios/browser/autofill_driver_ios.h (right): https://codereview.chromium.org/2849533003/diff/20001/components/autofill/ios/browser/autofill_driver_ios.h#newcode76 components/autofill/ios/browser/autofill_driver_ios.h:76: __unsafe_unretained id<AutofillDriverIOSBridge> bridge_; stk: do we have a ...
3 years, 7 months ago (2017-05-02 14:02:58 UTC) #8
stkhapugin
https://codereview.chromium.org/2849533003/diff/20001/components/autofill/ios/browser/autofill_driver_ios.h File components/autofill/ios/browser/autofill_driver_ios.h (right): https://codereview.chromium.org/2849533003/diff/20001/components/autofill/ios/browser/autofill_driver_ios.h#newcode76 components/autofill/ios/browser/autofill_driver_ios.h:76: __unsafe_unretained id<AutofillDriverIOSBridge> bridge_; On 2017/05/02 14:02:58, sdefresne wrote: > ...
3 years, 7 months ago (2017-05-02 14:08:48 UTC) #9
sdefresne
On 2017/05/02 14:08:48, stkhapugin wrote: > https://codereview.chromium.org/2849533003/diff/20001/components/autofill/ios/browser/autofill_driver_ios.h > File components/autofill/ios/browser/autofill_driver_ios.h (right): > > https://codereview.chromium.org/2849533003/diff/20001/components/autofill/ios/browser/autofill_driver_ios.h#newcode76 > ...
3 years, 7 months ago (2017-05-02 14:27:45 UTC) #10
stkhapugin
On 2017/05/02 14:27:45, sdefresne wrote: > On 2017/05/02 14:08:48, stkhapugin wrote: > > > https://codereview.chromium.org/2849533003/diff/20001/components/autofill/ios/browser/autofill_driver_ios.h ...
3 years, 7 months ago (2017-05-02 14:43:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849533003/20001
3 years, 7 months ago (2017-05-02 15:28:38 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:38:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5815c61aa07c697f16cd03a9affb...

Powered by Google App Engine
This is Rietveld 408576698