Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2852413002: Change id to instancetype in FormSuggestion (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change id to instancetype in FormSuggestion BUG=none R=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2852413002 Cr-Commit-Position: refs/heads/master@{#468908} Committed: https://chromium.googlesource.com/chromium/src/+/178f9bbc1e7d7a90e3bf1e4f8033cd65c0126cfc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M components/autofill/ios/browser/form_suggestion.mm View 2 chunks +8 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
gambard
PTAL, followup from ARC conversion.
3 years, 7 months ago (2017-05-02 15:30:47 UTC) #2
sdefresne
lgtm
3 years, 7 months ago (2017-05-02 15:44:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852413002/1
3 years, 7 months ago (2017-05-03 06:42:21 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 06:46:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/178f9bbc1e7d7a90e3bf1e4f8033...

Powered by Google App Engine
This is Rietveld 408576698