Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2807173003: [ObjC ARC] Converts components/autofill/ios/browser:browser to ARC.

Created:
3 years, 8 months ago by Olivier
Modified:
3 years, 8 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, ios-reviews_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts components/autofill/ios/browser:browser to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M components/autofill/ios/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/ios/browser/autofill_driver_ios.mm View 1 chunk +4 lines, -0 lines 1 comment Download
M components/autofill/ios/browser/credit_card_util.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M components/autofill/ios/browser/form_suggestion.mm View 4 chunks +7 lines, -7 lines 1 comment Download
M components/autofill/ios/browser/js_autofill_manager.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/ios/browser/js_suggestion_manager.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/ios/browser/personal_data_manager_observer_bridge.mm View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (5 generated)
Olivier
3 years, 8 months ago (2017-04-11 08:55:47 UTC) #6
stkhapugin
3 years, 8 months ago (2017-04-11 11:09:17 UTC) #7 
https://codereview.chromium.org/2807173003/diff/1/components/autofill/ios/bro...
File components/autofill/ios/browser/autofill_driver_ios.mm (right):

https://codereview.chromium.org/2807173003/diff/1/components/autofill/ios/bro...
components/autofill/ios/browser/autofill_driver_ios.mm:5: #include
"components/autofill/ios/browser/autofill_driver_ios.h"
The |bridge_| in this header should become unsafe_unretained or weak, I think.

https://codereview.chromium.org/2807173003/diff/1/components/autofill/ios/bro...
File components/autofill/ios/browser/form_suggestion.mm (right):

https://codereview.chromium.org/2807173003/diff/1/components/autofill/ios/bro...
components/autofill/ios/browser/form_suggestion.mm:21: NSString*
_displayDescription;
I think these ivars are no longer necessary and can be all synthesized.

https://codereview.chromium.org/2807173003/diff/1/components/autofill/ios/bro...
File components/autofill/ios/browser/personal_data_manager_observer_bridge.mm
(right):

https://codereview.chromium.org/2807173003/diff/1/components/autofill/ios/bro...
components/autofill/ios/browser/personal_data_manager_observer_bridge.mm:5:
#import
"components/autofill/ios/browser/personal_data_manager_observer_bridge.h"
In this header you need to annotate |delegate_| with weak or unsafe_unretained

Powered by Google App Engine
This is Rietveld 408576698