Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2848853002: webkitpy: Hide WebKitFinder.path_from_webkit_base(). (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Hide WebKitFinder.path_from_webkit_base(). BUG=710535 Review-Url: https://codereview.chromium.org/2848853002 Cr-Commit-Position: refs/heads/master@{#468261} Committed: https://chromium.googlesource.com/chromium/src/+/dbb0926440285d10f36d74a40065cbf1253ad77e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
jeffcarp@, would you review this please?
3 years, 7 months ago (2017-04-28 09:35:46 UTC) #4
jeffcarp
lgtm
3 years, 7 months ago (2017-04-28 22:21:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848853002/1
3 years, 7 months ago (2017-04-30 22:26:08 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-30 23:54:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbb0926440285d10f36d74a40065...

Powered by Google App Engine
This is Rietveld 408576698