Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py

Issue 2848853002: webkitpy: Hide WebKitFinder.path_from_webkit_base(). (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org) 1 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions 4 # modification, are permitted provided that the following conditions
5 # are met: 5 # are met:
6 # 1. Redistributions of source code must retain the above copyright 6 # 1. Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # 2. Redistributions in binary form must reproduce the above copyright 8 # 2. Redistributions in binary form must reproduce the above copyright
9 # notice, this list of conditions and the following disclaimer in the 9 # notice, this list of conditions and the following disclaimer in the
10 # documentation and/or other materials provided with the distribution. 10 # documentation and/or other materials provided with the distribution.
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 wkf.path_from_tools_scripts('webkitpy', 'thirdparty'), 81 wkf.path_from_tools_scripts('webkitpy', 'thirdparty'),
82 wkf.path_from_blink_source('bindings', 'scripts'), 82 wkf.path_from_blink_source('bindings', 'scripts'),
83 wkf.path_from_chromium_base('build', 'android'), 83 wkf.path_from_chromium_base('build', 'android'),
84 wkf.path_from_chromium_base('third_party', 'catapult', 'devil'), 84 wkf.path_from_chromium_base('third_party', 'catapult', 'devil'),
85 wkf.path_from_chromium_base('third_party', 'pymock'), 85 wkf.path_from_chromium_base('third_party', 'pymock'),
86 ]) 86 ])
87 return executive.run_command([ 87 return executive.run_command([
88 sys.executable, 88 sys.executable,
89 wkf.path_from_depot_tools_base('pylint.py'), 89 wkf.path_from_depot_tools_base('pylint.py'),
90 '--output-format=parseable', 90 '--output-format=parseable',
91 '--rcfile=' + wkf.path_from_webkit_base('Tools', 'Scripts', 'webkitp y', 'pylintrc'), 91 '--rcfile=' + wkf.path_from_tools_scripts('webkitpy', 'pylintrc'),
92 path, 92 path,
93 ], env=env, error_handler=executive.ignore_error) 93 ], env=env, error_handler=executive.ignore_error)
94 94
95 def _parse_pylint_output(self, output): 95 def _parse_pylint_output(self, output):
96 # We filter out these messages because they are bugs in pylint that prod uce false positives. 96 # We filter out these messages because they are bugs in pylint that prod uce false positives.
97 # FIXME: Does it make sense to combine these rules with the rules in sty le/checker.py somehow? 97 # FIXME: Does it make sense to combine these rules with the rules in sty le/checker.py somehow?
98 FALSE_POSITIVES = [ 98 FALSE_POSITIVES = [
99 # possibly http://www.logilab.org/ticket/98613 ? 99 # possibly http://www.logilab.org/ticket/98613 ?
100 "Instance of 'Popen' has no 'poll' member", 100 "Instance of 'Popen' has no 'poll' member",
101 "Instance of 'Popen' has no 'returncode' member", 101 "Instance of 'Popen' has no 'returncode' member",
(...skipping 15 matching lines...) Expand all
117 117
118 line_number = int(match_obj.group(2)) 118 line_number = int(match_obj.group(2))
119 category_and_method = match_obj.group(3).split(', ') 119 category_and_method = match_obj.group(3).split(', ')
120 category = 'pylint/' + (category_and_method[0]) 120 category = 'pylint/' + (category_and_method[0])
121 if len(category_and_method) > 1: 121 if len(category_and_method) > 1:
122 message = '[%s] %s' % (category_and_method[1], match_obj.group(4 )) 122 message = '[%s] %s' % (category_and_method[1], match_obj.group(4 ))
123 else: 123 else:
124 message = match_obj.group(4) 124 message = match_obj.group(4)
125 errors.append((line_number, category, message)) 125 errors.append((line_number, category, message))
126 return errors 126 return errors
OLDNEW
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698