Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py

Issue 2848853002: webkitpy: Hide WebKitFinder.path_from_webkit_base(). (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
index 7b4a97c2381ea58e2f8e344f7c0f4956695cecc7..1850740eb71bf8b8399639708a59f3eb07a1e220 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
@@ -105,10 +105,9 @@ class WebKitFinder(object):
self._chromium_base = self._filesystem.dirname(self._filesystem.dirname(self.webkit_base()))
return self._chromium_base
- # TODO(tkent): Make this private. We should use functions for
- # sub-directories in order to make the code robust against directory
- # structure changes.
- def path_from_webkit_base(self, *comps):
+ # Do not expose this function in order to make the code robust against
+ # directory structure changes.
+ def _path_from_webkit_base(self, *comps):
return self._filesystem.join(self.webkit_base(), *comps)
def path_from_chromium_base(self, *comps):
@@ -127,13 +126,13 @@ class WebKitFinder(object):
return self._filesystem.join(self._filesystem.join(self.webkit_base(), 'Tools', 'Scripts'), *comps)
def layout_tests_dir(self):
- return self.path_from_webkit_base('LayoutTests')
+ return self._path_from_webkit_base('LayoutTests')
def path_from_layout_tests(self, *comps):
return self._filesystem.join(self.layout_tests_dir(), *comps)
def perf_tests_dir(self):
- return self.path_from_webkit_base('PerformanceTests')
+ return self._path_from_webkit_base('PerformanceTests')
def layout_test_name(self, file_path):
"""Returns a layout test name, given the path from the repo root.
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698