Reland of SafeBrowsing: update interstitial layouts

Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of https://codereview.chromium.org/2848483004/ )

Reason for revert:
Fixing build breakages

Original issue's description:
> Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:160001 of https://codereview.chromium.org/2837233002/ )
> 
> Reason for revert:
> Bot breakages
> 
> Original issue's description:
> > Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of https://codereview.chromium.org/2842633002/ )
> > 
> > Reason for revert:
> > Fixing build issues
> > 
> > Original issue's description:
> > > Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001 of https://codereview.chromium.org/2788323002/ )
> > > 
> > > Reason for revert:
> > > This looks like the cause of failures here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29
> > > 
> > > First seen here:
> > > https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/37590
> > > 
> > > Original issue's description:
> > > > SafeBrowsing: change interstitial sizes
> > > > 
> > > > This CL changes the CSS max-height, max-width, etc. dimensions for
> > > > determining when to use mobile vs. desktop interstitial layouts. In
> > > > particular, it targets:
> > > > 
> > > >  * wide and short views -> mobile landscape
> > > >  * skinny and tall views -> mobile portrait
> > > >  * wide and medium-height -> mobile landscape (w/ details on the same page)
> > > > 
> > > > The phablet layout has been removed because it seems to actually be better
> > > > to just use the mobile layout instead.
> > > > 
> > > > This also allows the mobile layout to remain centered even for very wide
> > > > views (parts of it were left-justified before), and reduces the
> > > > top-margin for the icon in the mobile layout, since we were leaving a
> > > > huge gap.
> > > > 
> > > > BUG=707481
> > > > 
> > > > Review-Url: https://codereview.chromium.org/2788323002
> > > > Cr-Commit-Position: refs/heads/master@{#466746}
> > > > Committed: https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b3195563f71ec51
> > > 
> > > TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=707481
> > > 
> > > Review-Url: https://codereview.chromium.org/2842633002
> > > Cr-Commit-Position: refs/heads/master@{#466811}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee354946dc13b9
> > 
> > TBR=edwardjung@chromium.org,nparker@chromium.org,hcarmona@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=707481
> > 
> > Review-Url: https://codereview.chromium.org/2837233002
> > Cr-Commit-Position: refs/heads/master@{#467789}
> > Committed: https://chromium.googlesource.com/chromium/src/+/9a822f4b8c9d7d1ec7df123e48d24118ad102f00
> 
> TBR=edwardjung@chromium.org,felt@chromium.org,jialiul@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=707481
> 
> Review-Url: https://codereview.chromium.org/2848483004
> Cr-Commit-Position: refs/heads/master@{#467798}
> Committed: https://chromium.googlesource.com/chromium/src/+/6864beb8f21bf9a81c3c191f54f6ace40d7c108f

BUG=707481

[Nate Fischer, 2017-04-27 22:47:31]

Created Reland of SafeBrowsing: update interstitial layouts

[Nate Fischer, 2017-04-27 22:48:19]

Description was changed from

==========
Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of
https://codereview.chromium.org/2848483004/ )

Reason for revert:
Fixing build breakages

Original issue's description:
> Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:160001 of
https://codereview.chromium.org/2837233002/ )
> 
> Reason for revert:
> Bot breakages
> 
> Original issue's description:
> > Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of
https://codereview.chromium.org/2842633002/ )
> > 
> > Reason for revert:
> > Fixing build issues
> > 
> > Original issue's description:
> > > Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001
of https://codereview.chromium.org/2788323002/ )
> > > 
> > > Reason for revert:
> > > This looks like the cause of failures here:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...
> > > 
> > > First seen here:
> > >
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...
> > > 
> > > Original issue's description:
> > > > SafeBrowsing: change interstitial sizes
> > > > 
> > > > This CL changes the CSS max-height, max-width, etc. dimensions for
> > > > determining when to use mobile vs. desktop interstitial layouts. In
> > > > particular, it targets:
> > > > 
> > > >  * wide and short views -> mobile landscape
> > > >  * skinny and tall views -> mobile portrait
> > > >  * wide and medium-height -> mobile landscape (w/ details on the same
page)
> > > > 
> > > > The phablet layout has been removed because it seems to actually be
better
> > > > to just use the mobile layout instead.
> > > > 
> > > > This also allows the mobile layout to remain centered even for very wide
> > > > views (parts of it were left-justified before), and reduces the
> > > > top-margin for the icon in the mobile layout, since we were leaving a
> > > > huge gap.
> > > > 
> > > > BUG=707481
> > > > 
> > > > Review-Url: https://codereview.chromium.org/2788323002
> > > > Cr-Commit-Position: refs/heads/master@{#466746}
> > > > Committed:
https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b31...
> > > 
> > > TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=707481
> > > 
> > > Review-Url: https://codereview.chromium.org/2842633002
> > > Cr-Commit-Position: refs/heads/master@{#466811}
> > > Committed:
https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee...
> > 
> > TBR=edwardjung@chromium.org,nparker@chromium.org,hcarmona@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=707481
> > 
> > Review-Url: https://codereview.chromium.org/2837233002
> > Cr-Commit-Position: refs/heads/master@{#467789}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9a822f4b8c9d7d1ec7df123e48d2...
> 
> TBR=edwardjung@chromium.org,felt@chromium.org,jialiul@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=707481
> 
> Review-Url: https://codereview.chromium.org/2848483004
> Cr-Commit-Position: refs/heads/master@{#467798}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6864beb8f21bf9a81c3c191f54f6...

TBR=edwardjung@chromium.org,felt@chromium.org,jialiul@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707481
==========

to

==========
Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of
https://codereview.chromium.org/2848483004/ )

Reason for revert:
Fixing build breakages

Original issue's description:
> Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:160001 of
https://codereview.chromium.org/2837233002/ )
> 
> Reason for revert:
> Bot breakages
> 
> Original issue's description:
> > Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of
https://codereview.chromium.org/2842633002/ )
> > 
> > Reason for revert:
> > Fixing build issues
> > 
> > Original issue's description:
> > > Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001
of https://codereview.chromium.org/2788323002/ )
> > > 
> > > Reason for revert:
> > > This looks like the cause of failures here:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...
> > > 
> > > First seen here:
> > >
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...
> > > 
> > > Original issue's description:
> > > > SafeBrowsing: change interstitial sizes
> > > > 
> > > > This CL changes the CSS max-height, max-width, etc. dimensions for
> > > > determining when to use mobile vs. desktop interstitial layouts. In
> > > > particular, it targets:
> > > > 
> > > >  * wide and short views -> mobile landscape
> > > >  * skinny and tall views -> mobile portrait
> > > >  * wide and medium-height -> mobile landscape (w/ details on the same
page)
> > > > 
> > > > The phablet layout has been removed because it seems to actually be
better
> > > > to just use the mobile layout instead.
> > > > 
> > > > This also allows the mobile layout to remain centered even for very wide
> > > > views (parts of it were left-justified before), and reduces the
> > > > top-margin for the icon in the mobile layout, since we were leaving a
> > > > huge gap.
> > > > 
> > > > BUG=707481
> > > > 
> > > > Review-Url: https://codereview.chromium.org/2788323002
> > > > Cr-Commit-Position: refs/heads/master@{#466746}
> > > > Committed:
https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b31...
> > > 
> > > TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=707481
> > > 
> > > Review-Url: https://codereview.chromium.org/2842633002
> > > Cr-Commit-Position: refs/heads/master@{#466811}
> > > Committed:
https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee...
> > 
> > TBR=edwardjung@chromium.org,nparker@chromium.org,hcarmona@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=707481
> > 
> > Review-Url: https://codereview.chromium.org/2837233002
> > Cr-Commit-Position: refs/heads/master@{#467789}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9a822f4b8c9d7d1ec7df123e48d2...
> 
> TBR=edwardjung@chromium.org,felt@chromium.org,jialiul@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=707481
> 
> Review-Url: https://codereview.chromium.org/2848483004
> Cr-Commit-Position: refs/heads/master@{#467798}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6864beb8f21bf9a81c3c191f54f6...

BUG=707481
==========

[Nate Fischer, 2017-04-27 22:51:12]

The CQ bit was checked by ntfschr@chromium.org to run a CQ dry run

[Nate Fischer, 2017-04-27 22:51:27]

The CQ bit was unchecked by ntfschr@chromium.org

[Nate Fischer, 2017-04-27 22:51:27]

The CQ bit was unchecked by ntfschr@chromium.org

[Nate Fischer, 2017-04-27 22:51:27]

The CQ bit was unchecked by ntfschr@chromium.org

[Nate Fischer, 2017-04-27 22:51:28]

The CQ bit was unchecked by ntfschr@chromium.org

[Nate Fischer, 2017-04-27 22:51:30]

The CQ bit was unchecked by ntfschr@chromium.org

[Nate Fischer, 2017-04-27 23:44:19]

ntfschr@chromium.org changed reviewers:
- edwardjung@chromium.org

[Nate Fischer, 2017-04-27 23:44:19]

Ok, things should be fixed again.

+felt@ for security_interstitials/ (no changes since last reland)
+jialiul@ for safe_browsing_blocking_page_test.cc

The breakages happened because of https://codereview.chromium.org/2846673002.
learn-more-link is moved to main-content instead of details. I talked with him,
and he says tests should depend on the link being there.

The fix is just to change tests and check that learn-more-link is visible
*before* clicking the "details" button instead of after.

No change to UI stuff since the last reland.

And I've learned my lesson: I believe I removed all the weird NOTRY stuff
(correct me if I'm mistaken). LUCI bot repros the failure, so the latest
patchset should only pass if it really fixes the problem. And I'll run the full
CQ dry run to be extra safe in case it doesn't run when committing.

[Nate Fischer, 2017-04-28 17:26:04]

On 2017/04/27 at 23:44:19, Nate Fischer wrote:
> Ok, things should be fixed again.
> 
> +felt@ for security_interstitials/ (no changes since last reland)
> +jialiul@ for safe_browsing_blocking_page_test.cc
> 
> The breakages happened because of https://codereview.chromium.org/2846673002.
learn-more-link is moved to main-content instead of details. I talked with him,
and he says tests should depend on the link being there.
> 
> The fix is just to change tests and check that learn-more-link is visible
*before* clicking the "details" button instead of after.
> 
> No change to UI stuff since the last reland.
> 
> And I've learned my lesson: I believe I removed all the weird NOTRY stuff
(correct me if I'm mistaken). LUCI bot repros the failure, so the latest
patchset should only pass if it really fixes the problem. And I'll run the full
CQ dry run to be extra safe in case it doesn't run when committing.

Alright, since things keep breaking, I think I'll have to chop this CL up into
bits. I've already set out crrev/2845423002 and crrev/2845363003 for the
necessary fixes to the safe browsing browsertests. I'll try to investigate the
new breakages later today or on Monday.

[Nate Fischer, 2017-05-01 17:43:43]

The CQ bit was checked by ntfschr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 17:44:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 18:03:43]

Dry run: This issue passed the CQ dry run.

[felt, 2017-05-03 17:06:27]

On 2017/04/28 17:26:04, Nate Fischer wrote:
> On 2017/04/27 at 23:44:19, Nate Fischer wrote:
> > Ok, things should be fixed again.
> > 
> > +felt@ for security_interstitials/ (no changes since last reland)
> > +jialiul@ for safe_browsing_blocking_page_test.cc
> > 
> > The breakages happened because of
https://codereview.chromium.org/2846673002.
> learn-more-link is moved to main-content instead of details. I talked with
him,
> and he says tests should depend on the link being there.
> > 
> > The fix is just to change tests and check that learn-more-link is visible
> *before* clicking the "details" button instead of after.
> > 
> > No change to UI stuff since the last reland.
> > 
> > And I've learned my lesson: I believe I removed all the weird NOTRY stuff
> (correct me if I'm mistaken). LUCI bot repros the failure, so the latest
> patchset should only pass if it really fixes the problem. And I'll run the
full
> CQ dry run to be extra safe in case it doesn't run when committing.
> 
> Alright, since things keep breaking, I think I'll have to chop this CL up into
> bits. I've already set out crrev/2845423002 and crrev/2845363003 for the
> necessary fixes to the safe browsing browsertests. I'll try to investigate the
> new breakages later today or on Monday.

Could you please close this CL if you no longer need it? Thanks!