DescriptionRevert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001 of https://codereview.chromium.org/2788323002/ )
Reason for revert:
This looks like the cause of failures here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29
First seen here:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/37590
Original issue's description:
> SafeBrowsing: change interstitial sizes
>
> This CL changes the CSS max-height, max-width, etc. dimensions for
> determining when to use mobile vs. desktop interstitial layouts. In
> particular, it targets:
>
> * wide and short views -> mobile landscape
> * skinny and tall views -> mobile portrait
> * wide and medium-height -> mobile landscape (w/ details on the same page)
>
> The phablet layout has been removed because it seems to actually be better
> to just use the mobile layout instead.
>
> This also allows the mobile layout to remain centered even for very wide
> views (parts of it were left-justified before), and reduces the
> top-margin for the icon in the mobile layout, since we were leaving a
> huge gap.
>
> BUG=707481
>
> Review-Url: https://codereview.chromium.org/2788323002
> Cr-Commit-Position: refs/heads/master@{#466746}
> Committed: https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b3195563f71ec51
TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707481
Review-Url: https://codereview.chromium.org/2842633002
Cr-Commit-Position: refs/heads/master@{#466811}
Committed: https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee354946dc13b9
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|