Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2846673002: Move learn more link to the main section in security interstitials (Closed)

Created:
3 years, 8 months ago by meacer
Modified:
3 years, 8 months ago
Reviewers:
lgarron
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move learn more link to the main section in security interstitials BUG=674732 Review-Url: https://codereview.chromium.org/2846673002 Cr-Commit-Position: refs/heads/master@{#467525} Committed: https://chromium.googlesource.com/chromium/src/+/b9eec19bd79f6e7018f5dfdda37e54a37c4c0dd1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -44 lines) Patch
M components/security_interstitials/core/browser/resources/interstitial_v2.css View 1 1 chunk +0 lines, -3 lines 0 comments Download
M components/security_interstitials_strings.grdp View 7 chunks +18 lines, -18 lines 0 comments Download
M components/ssl_errors_strings.grdp View 7 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
meacer
lgarron: PTAL?
3 years, 8 months ago (2017-04-26 23:35:40 UTC) #6
lgarron
The bug mentions an experiment. Has it been decided that we want to move the ...
3 years, 8 months ago (2017-04-26 23:49:29 UTC) #7
meacer
On 2017/04/26 23:49:29, lgarron wrote: > The bug mentions an experiment. Has it been decided ...
3 years, 8 months ago (2017-04-26 23:56:47 UTC) #8
lgarron
lgtm https://codereview.chromium.org/2846673002/diff/1/components/security_interstitials/core/browser/resources/interstitial_v2.css File components/security_interstitials/core/browser/resources/interstitial_v2.css (right): https://codereview.chromium.org/2846673002/diff/1/components/security_interstitials/core/browser/resources/interstitial_v2.css#newcode101 components/security_interstitials/core/browser/resources/interstitial_v2.css:101: /*margin-top: 15px; Nit: Delete? If someone undoes this ...
3 years, 8 months ago (2017-04-27 00:01:56 UTC) #9
meacer
https://codereview.chromium.org/2846673002/diff/1/components/security_interstitials/core/browser/resources/interstitial_v2.css File components/security_interstitials/core/browser/resources/interstitial_v2.css (right): https://codereview.chromium.org/2846673002/diff/1/components/security_interstitials/core/browser/resources/interstitial_v2.css#newcode101 components/security_interstitials/core/browser/resources/interstitial_v2.css:101: /*margin-top: 15px; On 2017/04/27 00:01:56, lgarron wrote: > Nit: ...
3 years, 8 months ago (2017-04-27 00:09:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846673002/20001
3 years, 8 months ago (2017-04-27 00:10:25 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 00:28:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9eec19bd79f6e7018f5dfdda37e...

Powered by Google App Engine
This is Rietveld 408576698