Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2848483004: Revert of SafeBrowsing: update interstitial layouts (Closed)

Created:
3 years, 7 months ago by Nate Fischer
Modified:
3 years, 7 months ago
Reviewers:
edwardjung, felt, Jialiu Lin
CC:
chromium-reviews, felt, Nathan Parker
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:160001 of https://codereview.chromium.org/2837233002/ ) Reason for revert: Bot breakages Original issue's description: > Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of https://codereview.chromium.org/2842633002/ ) > > Reason for revert: > Fixing build issues > > Original issue's description: > > Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001 of https://codereview.chromium.org/2788323002/ ) > > > > Reason for revert: > > This looks like the cause of failures here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29 > > > > First seen here: > > https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/37590 > > > > Original issue's description: > > > SafeBrowsing: change interstitial sizes > > > > > > This CL changes the CSS max-height, max-width, etc. dimensions for > > > determining when to use mobile vs. desktop interstitial layouts. In > > > particular, it targets: > > > > > > * wide and short views -> mobile landscape > > > * skinny and tall views -> mobile portrait > > > * wide and medium-height -> mobile landscape (w/ details on the same page) > > > > > > The phablet layout has been removed because it seems to actually be better > > > to just use the mobile layout instead. > > > > > > This also allows the mobile layout to remain centered even for very wide > > > views (parts of it were left-justified before), and reduces the > > > top-margin for the icon in the mobile layout, since we were leaving a > > > huge gap. > > > > > > BUG=707481 > > > > > > Review-Url: https://codereview.chromium.org/2788323002 > > > Cr-Commit-Position: refs/heads/master@{#466746} > > > Committed: https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b3195563f71ec51 > > > > TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=707481 > > > > Review-Url: https://codereview.chromium.org/2842633002 > > Cr-Commit-Position: refs/heads/master@{#466811} > > Committed: https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee354946dc13b9 > > TBR=edwardjung@chromium.org,nparker@chromium.org,hcarmona@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=707481 > > Review-Url: https://codereview.chromium.org/2837233002 > Cr-Commit-Position: refs/heads/master@{#467789} > Committed: https://chromium.googlesource.com/chromium/src/+/9a822f4b8c9d7d1ec7df123e48d24118ad102f00 TBR=edwardjung@chromium.org,felt@chromium.org,jialiul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707481 Review-Url: https://codereview.chromium.org/2848483004 Cr-Commit-Position: refs/heads/master@{#467798} Committed: https://chromium.googlesource.com/chromium/src/+/6864beb8f21bf9a81c3c191f54f6ace40d7c108f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -58 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 chunk +7 lines, -20 lines 0 comments Download
M components/security_interstitials/core/browser/resources/interstitial_v2.css View 6 chunks +148 lines, -35 lines 0 comments Download
M components/security_interstitials/core/browser/resources/interstitial_v2_mobile.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nate Fischer
Created Revert of SafeBrowsing: update interstitial layouts
3 years, 7 months ago (2017-04-27 22:29:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848483004/1
3 years, 7 months ago (2017-04-27 22:31:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6864beb8f21bf9a81c3c191f54f6ace40d7c108f
3 years, 7 months ago (2017-04-27 22:34:25 UTC) #6
Nate Fischer
3 years, 7 months ago (2017-04-27 22:47:31 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2848733002/ by ntfschr@chromium.org.

The reason for reverting is: Fixing build breakages.

Powered by Google App Engine
This is Rietveld 408576698