Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2848663002: 📰 Correctly remove content while resetting suggestions (Closed)

Created:
3 years, 7 months ago by dgn
Modified:
3 years, 7 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Suggestions] Correctly remove content while resetting suggestions Fixes a bug causing suggestions to be added to the bottom sheet's Home tab every time it's opened. BUG=689962 Review-Url: https://codereview.chromium.org/2848663002 Cr-Commit-Position: refs/heads/master@{#467773} Committed: https://chromium.googlesource.com/chromium/src/+/b123de4c0af67ecec411e3ff4d95f5f24ac53baf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java View 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgn
PTAL
3 years, 7 months ago (2017-04-27 16:00:21 UTC) #3
Michael van Ouwerkerk
Neat :-) lgtm
3 years, 7 months ago (2017-04-27 16:25:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848663002/1
3 years, 7 months ago (2017-04-27 20:12:11 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 20:38:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b123de4c0af67ecec411e3ff4d95...

Powered by Google App Engine
This is Rietveld 408576698