chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java - Issue 2848663002: 📰 Correctly remove content while resetting suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

Issue 2848663002: 📰 Correctly remove content while resetting suggestions (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

index b70c0ed6cce9b7be334c7424fcbb09da9c1ce199..fad7e9891e5c8bd37fd9f1935c5623c6a54c033b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

@@ -110,6 +110,8 @@ private int resetSection(@CategoryInt int category, @CategoryStatus int category

mSections.put(category, section);

mSuggestionsRanker.registerCategory(category);

addChild(section);

+ } else {

+ section.clearData();

}

// Set the new suggestions.

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | no next file with comments »