chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java - Issue 2848663002: 📰 Correctly remove content while resetting suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2848663002: 📰 Correctly remove content while resetting suggestions (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

index 40b7e358dcd6584059ffef20b9c6c1a87434ad01..85540c7dfd12a4cb3bf70173fee29b7ce0d345b6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

@@ -464,7 +464,7 @@ public void setStatus(@CategoryStatus int status) {

}

/** Clears the suggestions and related data, resetting the state of the section. */

- private void clearData() {

+ public void clearData() {

mSuggestionsList.clear();

mNumberOfSuggestionsSeen = 0;

mHasAppended = false;