Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2848313003: Revert of Remove client_certs from SSLCertRequestInfo. (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, tburkard+watch_chromium.org, tfarina, jam, Randy Smith (Not in Mondays), net-reviews_chromium.org, gavinp+prer_chromium.org, darin-cc_chromium.org, mmenke, oshima+watch_chromium.org, mac-reviews_chromium.org, loading-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove client_certs from SSLCertRequestInfo. (patchset #4 id:60001 of https://codereview.chromium.org/2838243002/ ) Reason for revert: Reverting in hopes of fixing 716594 . Will reland if it turns out to be another patch. Original issue's description: > Remove client_certs from SSLCertRequestInfo. > > The client_certs aren't actually part of the certificate request, rather the client_certs member was used to store the list of matching certificates on the client side and pass them through to the certificate selector. > Pass the list of certs through the relevant callbacks instead. > > BUG=166642, 394131 > > Review-Url: https://codereview.chromium.org/2838243002 > Cr-Commit-Position: refs/heads/master@{#467901} > Committed: https://chromium.googlesource.com/chromium/src/+/7ed243fc89fb72230c47f59742128add62ae1d83 TBR=davidben@chromium.org,sergeyu@chromium.org,lcwu@chromium.org,sgurun@chromium.org,pfeldman@chromium.org,emaxx@chromium.org,rsleevi@chromium.org,tedchoc@chromium.org,ellyjones@chromium.org,msw@chromium.org,dougsteed@chromium.org,ryanchung@chromium.org,mattm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=166642, 394131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -274 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/net/client_cert_store_chromeos.h View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/net/client_cert_store_chromeos.cc View 5 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/net/client_cert_store_chromeos_unittest.cc View 6 chunks +10 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_nss.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector.h View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/ssl_client_certificate_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm View 5 chunks +5 lines, -48 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 9 chunks +12 lines, -17 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 4 chunks +12 lines, -10 lines 0 comments Download
M content/browser/ssl/ssl_client_auth_handler.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/ssl/ssl_client_auth_handler.cc View 7 chunks +12 lines, -13 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/socket_test_util.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/ssl/client_cert_store.h View 1 chunk +4 lines, -6 lines 0 comments Download
M net/ssl/client_cert_store_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/ssl/client_cert_store_mac.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M net/ssl/client_cert_store_nss.h View 2 chunks +5 lines, -3 lines 0 comments Download
M net/ssl/client_cert_store_nss.cc View 3 chunks +14 lines, -15 lines 0 comments Download
M net/ssl/client_cert_store_nss_unittest.cc View 4 chunks +2 lines, -18 lines 0 comments Download
M net/ssl/client_cert_store_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/ssl/client_cert_store_win.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M net/ssl/ssl_cert_request_info.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/ssl/ssl_cert_request_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/token_validator_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/token_validator_base.cc View 1 chunk +11 lines, -9 lines 0 comments Download
M remoting/host/token_validator_base_unittest.cc View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sky
Created Revert of Remove client_certs from SSLCertRequestInfo.
3 years, 7 months ago (2017-05-01 19:27:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848313003/1
3 years, 7 months ago (2017-05-01 19:28:05 UTC) #3
mattm
3 years, 7 months ago (2017-05-01 19:58:39 UTC) #4
On 2017/05/01 19:28:05, commit-bot: I haz the power wrote:
> CQ is trying da patch.
> 
> Follow status at:
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
has the same failure at revision 467879, which is before 
https://codereview.chromium.org/2838243002 (467901)

Powered by Google App Engine
This is Rietveld 408576698