Remove client_certs from SSLCertRequestInfo.

Remove client_certs from SSLCertRequestInfo.

The client_certs aren't actually part of the certificate request, rather the client_certs member was used to store the list of matching certificates on the client side and pass them through to the certificate selector.
Pass the list of certs through the relevant callbacks instead.

BUG=166642, 394131
Review-Url: https://codereview.chromium.org/2838243002
Cr-Commit-Position: refs/heads/master@{#467901}
Committed: https://chromium.googlesource.com/chromium/src/+/7ed243fc89fb72230c47f59742128add62ae1d83

[mattm, 2017-04-25 20:14:19]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 20:15:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-25 20:16:58]

Description was changed from

==========
Remove client_certs from SSLCertRequestInfo.

The client_certs aren't actually part of the certificate request, rather the
client_certs member was used to store the list of matching certificates on the
client side and pass them through to the certificate selector. This is
confusing and unnecessary.  Pass the list of certs through the relevant
callbacks instead.

BUG=166642,394131
==========

to

==========
Remove client_certs from SSLCertRequestInfo.

The client_certs aren't actually part of the certificate request, rather the
client_certs member was used to store the list of matching certificates on the
client side and pass them through to the certificate selector.
Pass the list of certs through the relevant callbacks instead.

BUG=166642,394131
==========

[mattm, 2017-04-25 20:21:35]

mattm@chromium.org changed reviewers:
+ davidben@chromium.org

[commit-bot: I haz the power, 2017-04-25 20:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 20:34:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mattm, 2017-04-25 20:53:05]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 20:53:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 21:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:25:10]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[mattm, 2017-04-25 21:38:56]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 21:39:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 00:06:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:06:36]

Dry run: This issue passed the CQ dry run.

[davidben, 2017-04-26 02:37:56]

lgtm!

https://codereview.chromium.org/2838243002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/platform_keys/platform_keys_nss.cc (left):

https://codereview.chromium.org/2838243002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:271: 
Stray change?

https://codereview.chromium.org/2838243002/diff/40001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
(right):

https://codereview.chromium.org/2838243002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm:87:
ASSERT_TRUE(mit_davidben_cert_.get());
I love how this thing is *still* in here...

[Sergey Ulanov, 2017-04-26 02:52:14]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2017-04-26 02:52:14]

remoting lgtm

[mattm, 2017-04-26 03:45:02]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 03:45:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-26 04:46:15]

mattm@chromium.org changed reviewers:
+ ellyjones@chromium.org, emaxx@chromium.org, lcwu@chromium.org,
msw@chromium.org, pfeldman@chromium.org, rsleevi@chromium.org,
sgurun@chromium.org, tedchoc@chromium.org

[mattm, 2017-04-26 04:46:16]

+OWNERS reviewers:
lcwu: chromecast/
sgurun: android_webview/
pfeldman: content/
emaxx: chrome/browser/chromeos/platform_keys/
rsleevi: chrome/browser/ssl/
tedchoc: chrome/browser/ui/android/
ellyjones: chrome/browser/ui/cocoa/
msw: chrome/browser/ui/views/

https://codereview.chromium.org/2838243002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/platform_keys/platform_keys_nss.cc (left):

https://codereview.chromium.org/2838243002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:271: 
On 2017/04/26 02:37:56, davidben wrote:
> Stray change?

Done.

https://codereview.chromium.org/2838243002/diff/40001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
(right):

https://codereview.chromium.org/2838243002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm:87:
ASSERT_TRUE(mit_davidben_cert_.get());
On 2017/04/26 02:37:56, davidben wrote:
> I love how this thing is *still* in here...

heh, yep.

[lcwu1, 2017-04-26 04:56:11]

lcwu@chromium.org changed reviewers:
+ dougsteed@chromium.org, ryanchung@chromium.org

[commit-bot: I haz the power, 2017-04-26 05:02:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 05:02:13]

Dry run: This issue passed the CQ dry run.

[sgurun-gerrit only, 2017-04-26 06:25:40]

On 2017/04/26 04:56:12, lcwu1 wrote:

aw lgtm

[lcwu1, 2017-04-26 07:09:14]

chromecast/ lgtm

[Elly Fong-Jones, 2017-04-26 12:41:47]

On 2017/04/26 07:09:14, lcwu1 wrote:
> chromecast/ lgtm

c/b/ui/cocoa lgtm

[Ryan Sleevi, 2017-04-26 12:44:44]

lgtm

[emaxx, 2017-04-26 15:31:18]

lgtm for chrome/browser/chromeos/platform_keys/

[Ted C, 2017-04-26 17:43:30]

On 2017/04/26 15:31:18, emaxx wrote:
> lgtm for chrome/browser/chromeos/platform_keys/

chrome/browser/ui/android/ - lgtm

[msw, 2017-04-26 19:40:17]

c/b/ui/views rubber stamp lgtm

[pfeldman, 2017-04-27 21:47:38]

content/ lgtm

[mattm, 2017-04-27 21:52:20]

The CQ bit was checked by mattm@chromium.org

[mattm, 2017-04-27 21:52:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2838243002/#ps60001
(title: "revert stray whitespace change")

[commit-bot: I haz the power, 2017-04-27 21:53:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 22:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 22:54:23]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mattm, 2017-04-27 22:56:22]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:33:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 04:45:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 04:45:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattm, 2017-04-28 04:45:45]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-04-28 04:46:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 05:29:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493354745690370,
"parent_rev": "dbd0203fc10fbaeae74d56a90f78bc9ec71809cd", "commit_rev":
"7ed243fc89fb72230c47f59742128add62ae1d83"}

[commit-bot: I haz the power, 2017-04-28 05:29:09]

Description was changed from

==========
Remove client_certs from SSLCertRequestInfo.

The client_certs aren't actually part of the certificate request, rather the
client_certs member was used to store the list of matching certificates on the
client side and pass them through to the certificate selector.
Pass the list of certs through the relevant callbacks instead.

BUG=166642,394131
==========

to

==========
Remove client_certs from SSLCertRequestInfo.

The client_certs aren't actually part of the certificate request, rather the
client_certs member was used to store the list of matching certificates on the
client side and pass them through to the certificate selector.
Pass the list of certs through the relevant callbacks instead.

BUG=166642,394131

Review-Url: https://codereview.chromium.org/2838243002
Cr-Commit-Position: refs/heads/master@{#467901}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ed243fc89fb72230c47f5974212...
==========

[commit-bot: I haz the power, 2017-04-28 05:29:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7ed243fc89fb72230c47f5974212...

[sky, 2017-05-01 19:27:33]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2848313003/ by sky@chromium.org.

The reason for reverting is: Reverting in hopes of fixing 716594 . Will reland
if it turns out to be another patch..