Revert of Remove client_certs from SSLCertRequestInfo.

remoting/host/token_validator_base_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/token_validator_base.h"
 
 #include <vector>
 
 #include "base/atomic_sequence_num.h"
 #include "crypto/rsa_private_key.h"
@@ skipping 21 matching lines @@
 
 }  // namespace
 
 namespace remoting {
 
 class TestTokenValidator : TokenValidatorBase {
  public:
   explicit TestTokenValidator(const ThirdPartyAuthConfig& config);
   ~TestTokenValidator() override;
 
-  void SelectCertificates(net::CertificateList selected_certs);
+  void SelectCertificates(net::CertificateList* selected_certs);
 
   void ExpectContinueWithCertificate(net::X509Certificate* client_cert);
 
  protected:
   void ContinueWithCertificate(net::X509Certificate* client_cert,
                                net::SSLPrivateKey* client_private_key) override;
 
  private:
   void StartValidateRequest(const std::string& token) override {}
 
   net::X509Certificate* expected_client_cert_ = nullptr;
 };
 
 TestTokenValidator::TestTokenValidator(const ThirdPartyAuthConfig& config) :
     TokenValidatorBase(config, "", nullptr) {
 }
 
 TestTokenValidator::~TestTokenValidator() {}
 
 void TestTokenValidator::SelectCertificates(
-    net::CertificateList selected_certs) {
-  OnCertificatesSelected(nullptr, std::move(selected_certs));
+    net::CertificateList* selected_certs) {
+  OnCertificatesSelected(selected_certs, nullptr);
 }
 
 void TestTokenValidator::ExpectContinueWithCertificate(
     net::X509Certificate* client_cert) {
   expected_client_cert_ = client_cert;
 }
 
 void TestTokenValidator::ContinueWithCertificate(
     net::X509Certificate* client_cert,
     net::SSLPrivateKey* client_private_key) {
@@ skipping 34 matching lines @@
   ASSERT_TRUE(cert_start_10min_expire_5min);
 
   scoped_refptr<net::X509Certificate> cert_start_5min_expire_10min =
       CreateFakeCert(now - base::TimeDelta::FromMinutes(5),
                                         now + base::TimeDelta::FromMinutes(10));
   ASSERT_TRUE(cert_start_5min_expire_10min);
 
   // No certificate.
   net::CertificateList certificates {};
   token_validator_->ExpectContinueWithCertificate(nullptr);
-  token_validator_->SelectCertificates(std::move(certificates));
+  token_validator_->SelectCertificates(&certificates);
 
   // One invalid certificate.
   certificates = { cert_expired_5_minutes_ago };
   token_validator_->ExpectContinueWithCertificate(nullptr);
-  token_validator_->SelectCertificates(std::move(certificates));
+  token_validator_->SelectCertificates(&certificates);
 
   // One valid certificate.
   certificates = { cert_start_5min_expire_5min };
   token_validator_->ExpectContinueWithCertificate(
       cert_start_5min_expire_5min.get());
-  token_validator_->SelectCertificates(std::move(certificates));
+  token_validator_->SelectCertificates(&certificates);
 
   // One valid one invalid.
   certificates = { cert_expired_5_minutes_ago, cert_start_5min_expire_5min };
   token_validator_->ExpectContinueWithCertificate(
       cert_start_5min_expire_5min.get());
-  token_validator_->SelectCertificates(std::move(certificates));
+  token_validator_->SelectCertificates(&certificates);
 
   // Two valid certs. Choose latest created.
   certificates = { cert_start_10min_expire_5min, cert_start_5min_expire_5min };
   token_validator_->ExpectContinueWithCertificate(
       cert_start_5min_expire_5min.get());
-  token_validator_->SelectCertificates(std::move(certificates));
+  token_validator_->SelectCertificates(&certificates);
 
   // Two valid certs. Choose latest expires.
   certificates = { cert_start_5min_expire_5min, cert_start_5min_expire_10min };
   token_validator_->ExpectContinueWithCertificate(
       cert_start_5min_expire_10min.get());
-  token_validator_->SelectCertificates(std::move(certificates));
+  token_validator_->SelectCertificates(&certificates);
 
   // Pick the best given all certificates.
   certificates = { cert_expired_5_minutes_ago, cert_start_5min_expire_5min,
       cert_start_5min_expire_10min, cert_start_10min_expire_5min };
     token_validator_->ExpectContinueWithCertificate(
         cert_start_5min_expire_10min.get());
-    token_validator_->SelectCertificates(std::move(certificates));
+    token_validator_->SelectCertificates(&certificates);
 }
 
 }  // namespace remoting