VR: Refresh controller handedness when resuming the controller.

VR: Refresh controller handedness when resuming the controller.

Thanks to Aldo's elbow model implementation, we already support handedness controls. This CL does some clean up to make sure we're refreshing it when we should.

BUG=703287
Review-Url: https://codereview.chromium.org/2848283003
Cr-Commit-Position: refs/heads/master@{#468678}
Committed: https://chromium.googlesource.com/chromium/src/+/a75e2f6c06fdf268d20184a2a2f8f521a7229dbf

[mthiesse, 2017-05-01 21:49:39]

Patchset #1 (id:1) has been deleted

[mthiesse, 2017-05-01 21:50:01]

mthiesse@chromium.org changed reviewers:
+ acondor@google.com, asimjour@chromium.org

[mthiesse, 2017-05-01 21:50:02]

PTAL

[asimjour1, 2017-05-01 21:55:12]

On 2017/05/01 21:50:02, mthiesse wrote:
> PTAL

lgtm

[cjgrant, 2017-05-02 13:31:44]

cjgrant@chromium.org changed reviewers:
+ cjgrant@chromium.org

[cjgrant, 2017-05-02 13:31:45]

lgtm

[acondor_, 2017-05-02 14:18:35]

lgtm with the small fix.

https://codereview.chromium.org/2848283003/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/elbow_model.cc (right):

https://codereview.chromium.org/2848283003/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/elbow_model.cc:42: if (handedness ==
handedness_)
We might need an invalid default handedness value so this is always false on
construction.

[mthiesse, 2017-05-02 15:23:37]

https://codereview.chromium.org/2848283003/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/elbow_model.cc (right):

https://codereview.chromium.org/2848283003/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/elbow_model.cc:42: if (handedness ==
handedness_)
On 2017/05/02 14:18:34, acondor wrote:
> We might need an invalid default handedness value so this is always false on
> construction.

Done.

[mthiesse, 2017-05-02 15:23:41]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-05-02 15:23:41]

The patchset sent to the CQ was uploaded after l-g-t-m from acondor@google.com,
asimjour@chromium.org, cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2848283003/#ps40001
(title: "Adress comment")

[commit-bot: I haz the power, 2017-05-02 15:24:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 15:28:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 15:28:19]

Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mthiesse, 2017-05-02 15:39:16]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-05-02 15:39:16]

The patchset sent to the CQ was uploaded after l-g-t-m from acondor@google.com,
asimjour@chromium.org, cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2848283003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-02 15:39:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 16:40:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493739556329730,
"parent_rev": "5815c61aa07c697f16cd03a9affb47952314e000", "commit_rev":
"a75e2f6c06fdf268d20184a2a2f8f521a7229dbf"}

[commit-bot: I haz the power, 2017-05-02 16:40:28]

Description was changed from

==========
VR: Refresh controller handedness when resuming the controller.

Thanks to Aldo's elbow model implementation, we already support handedness
controls. This CL does some clean up to make sure we're refreshing it when we
should.

BUG=703287
==========

to

==========
VR: Refresh controller handedness when resuming the controller.

Thanks to Aldo's elbow model implementation, we already support handedness
controls. This CL does some clean up to make sure we're refreshing it when we
should.

BUG=703287

Review-Url: https://codereview.chromium.org/2848283003
Cr-Commit-Position: refs/heads/master@{#468678}
Committed:
https://chromium.googlesource.com/chromium/src/+/a75e2f6c06fdf268d20184a2a2f8...
==========

[commit-bot: I haz the power, 2017-05-02 16:40:29]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a75e2f6c06fdf268d20184a2a2f8...