Cleanup LayoutTests that define a function gc().

Cleanup LayoutTests that define a function gc().

There are some LayoutTests that define their
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

BUG=706285
Review-Url: https://codereview.chromium.org/2847943002
Cr-Commit-Position: refs/heads/master@{#468757}
Committed: https://chromium.googlesource.com/chromium/src/+/0ce4fda39a836c2f345c78a00374b2776aa9e1d2

[nikhil.sahni, 2017-04-28 09:07:10]

Description was changed from

==========
Cleanup LayoutTests that define a function gc().

There are some LayoutTests that define there
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

BUG=706285
==========

to

==========
Cleanup LayoutTests that define a function gc().

There are some LayoutTests that define there
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

BUG=706285

R=SamsungPeerReview
==========

[nikhil.sahni, 2017-04-28 09:07:11]

nikhil.sahni@samsung.com changed reviewers:
+ shanmuga.m@samsung.com, srirama.m@samsung.com

[Srirama, 2017-04-28 09:09:14]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 09:09:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Srirama, 2017-04-28 09:39:56]

In Description s/there/their

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:7:
<script src="../../../resources/gc.js"></script>
move it up inside head element

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:7:
<script src="../../../resources/gc.js"></script>
ditto

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/node-iterator-reference-node-moved-crash.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/node-iterator-reference-node-moved-crash.html:4:
<script src="../../resources/gc.js"></script>
move it outside script tag.

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/workers/worker-supplement-gc.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/workers/worker-supplement-gc.html:4: <script
src="../../resources/gc.js"></script>
move it above to group it

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html:7:
<script src="../resources/gc.js"></script>
move it above

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html:8:
<script src="../../../resources/gc.js"></script>
move it above

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/remoteplayback/availability-callback-gc.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/remoteplayback/availability-callback-gc.html:8:
<script src="../../resources/gc.js"></script>
move it above

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-promise-gc.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-promise-gc.html:7:
<script src="../resources/gc.js"></script>
move it above

[nikhil.sahni, 2017-04-28 09:40:50]

Description was changed from

==========
Cleanup LayoutTests that define a function gc().

There are some LayoutTests that define there
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

BUG=706285

R=SamsungPeerReview
==========

to

==========
Cleanup LayoutTests that define a function gc().

There are some LayoutTests that define their
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

BUG=706285

R=SamsungPeerReview
==========

[nikhil.sahni, 2017-04-28 10:08:48]

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:7:
<script src="../../../resources/gc.js"></script>
On 2017/04/28 09:39:55, Srirama wrote:
> move it up inside head element

Done.

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:7:
<script src="../../../resources/gc.js"></script>
On 2017/04/28 09:39:55, Srirama wrote:
> ditto

Done.

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/node-iterator-reference-node-moved-crash.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/node-iterator-reference-node-moved-crash.html:4:
<script src="../../resources/gc.js"></script>
On 2017/04/28 09:39:55, Srirama wrote:
> move it outside script tag.

Done.

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html:8:
<script src="../../../resources/gc.js"></script>
On 2017/04/28 09:39:55, Srirama wrote:
> move it above

Done.

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-promise-gc.html
(right):

https://codereview.chromium.org/2847943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-finish-promise-gc.html:7:
<script src="../resources/gc.js"></script>
On 2017/04/28 09:39:55, Srirama wrote:
> move it above

Done.

[Srirama, 2017-04-28 12:52:47]

Peer review is fine

[nikhil.sahni, 2017-04-28 12:56:08]

Description was changed from

==========
Cleanup LayoutTests that define a function gc().

There are some LayoutTests that define their
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

BUG=706285

R=SamsungPeerReview
==========

to

==========
Cleanup LayoutTests that define a function gc().

There are some LayoutTests that define their
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

BUG=706285
==========

[nikhil.sahni, 2017-04-28 12:56:08]

nikhil.sahni@samsung.com changed reviewers:
+ esprehn@chromium.org, jbroman@chromium.org

[Srirama, 2017-04-28 12:56:35]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 12:56:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 15:05:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 15:05:19]

Dry run: This issue passed the CQ dry run.

[nikhil.sahni, 2017-05-02 07:45:15]

Hello jbroman,

All layout test cases are passed and peer reviewis done...please let me know
tour views on it.

Thank you so much.

[jbroman, 2017-05-02 14:46:20]

lgtm

[nikhil.sahni, 2017-05-02 17:25:06]

The CQ bit was checked by nikhil.sahni@samsung.com

[commit-bot: I haz the power, 2017-05-02 17:25:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 20:17:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493745906129740,
"parent_rev": "1c906dc6495ff5c831a19b72a1f8fb265d1eacf6", "commit_rev":
"0ce4fda39a836c2f345c78a00374b2776aa9e1d2"}

[commit-bot: I haz the power, 2017-05-02 20:17:34]

Description was changed from

==========
Cleanup LayoutTests that define a function gc().

There are some LayoutTests that define their
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

BUG=706285
==========

to

==========
Cleanup LayoutTests that define a function gc().

There are some LayoutTests that define their
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

BUG=706285

Review-Url: https://codereview.chromium.org/2847943002
Cr-Commit-Position: refs/heads/master@{#468757}
Committed:
https://chromium.googlesource.com/chromium/src/+/0ce4fda39a836c2f345c78a00374...
==========

[commit-bot: I haz the power, 2017-05-02 20:17:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0ce4fda39a836c2f345c78a00374...