third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html - Issue 2847943002: Cleanup LayoutTests that define a function gc().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html

Issue 2847943002: Cleanup LayoutTests that define a function gc(). (Closed)

Patch Set: Fixing Layout Tests Failures Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../resources/js-test.js"></script>	4 <script src="../resources/js-test.js"></script>

5 <script src="../resources/mojo-helpers.js"></script>	5 <script src="../resources/mojo-helpers.js"></script>

	6 <script src="../resources/gc.js"></script>

6 <script src="resources/geolocation-mock.js"></script>	7 <script src="resources/geolocation-mock.js"></script>

7 </head>	8 </head>

8 <body>	9 <body>

9 <script>	10 <script>

10 description("Tests that we do not crash when a Geolocation request is made from a remote frame, which is then removed from the DOM in the error callback.");	11 description("Tests that we do not crash when a Geolocation request is made from a remote frame, which is then removed from the DOM in the error callback.");

11	12

12 function gc() {

13 if (window.GCController) {

14 GCController.collect();

15 return;

16 }

17

18 for (var i = 0; i < 10000; i++)

19 new String(i);

20 }

21

22 function onIframeReady() {	13 function onIframeReady() {

23 // Make request from remote frame	14 // Make request from remote frame

24 iframe.contentWindow.navigator.geolocation.getCurrentPosition(function() {	15 iframe.contentWindow.navigator.geolocation.getCurrentPosition(function() {

25 testFailed('Success callback invoked unexpectedly');	16 testFailed('Success callback invoked unexpectedly');

26 finishJSTest();	17 finishJSTest();

27 }, function() {	18 }, function() {

28 testPassed('Error callback invoked.');	19 testPassed('Error callback invoked.');

29 document.body.removeChild(iframe);	20 document.body.removeChild(iframe);

30 gc();	21 gc();

31 finishJSTest();	22 finishJSTest();

32 });	23 });

33 }	24 }

34	25

35 var iframe = document.createElement('iframe');	26 var iframe = document.createElement('iframe');

36 iframe.src = 'resources/remove-remote-context-in-error-callback-crash-inner.html ';	27 iframe.src = 'resources/remove-remote-context-in-error-callback-crash-inner.html ';

37 document.body.appendChild(iframe);	28 document.body.appendChild(iframe);

38	29

39 window.jsTestIsAsync = true;	30 window.jsTestIsAsync = true;

40 </script>	31 </script>

41 </body>	32 </body>

42 </html>	33 </html>

OLD	NEW