third_party/WebKit/LayoutTests/fast/forms/dangling-form-element-crash.html - Issue 2847943002: Cleanup LayoutTests that define a function gc().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/dangling-form-element-crash.html

Issue 2847943002: Cleanup LayoutTests that define a function gc(). (Closed)

Patch Set: Fixing Layout Tests Failures Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/change-form-element-document-crash.html ('k') | third_party/WebKit/LayoutTests/fast/forms/form-associated-element-crash2.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

	2 <script src="../../resources/gc.js"></script>

2 <script>	3 <script>

3 if (window.testRunner) {	4 if (window.testRunner) {

4 testRunner.dumpAsText();	5 testRunner.dumpAsText();

5 testRunner.waitUntilDone();	6 testRunner.waitUntilDone();

6 }	7 }

7	8

8 function gc() {

9 if (window.GCController)

10 return GCController.collectAll();

11 for (var i = 0; i < 10000; ++i)

12 var s = new String("foo");

13 }

14

15 function resetFormOwner() {	9 function resetFormOwner() {

16 gc();	10 gc();

17 var form = document.createElement('form');	11 var form = document.createElement('form');

18 form.id = 'foo';	12 form.id = 'foo';

19 document.body.appendChild(form);	13 document.body.appendChild(form);

20 document.body.innerHTML += 'PASS';	14 document.body.innerHTML += 'PASS';

21 if (window.testRunner)	15 if (window.testRunner)

22 testRunner.notifyDone();	16 testRunner.notifyDone();

23 }	17 }

24	18

25 function test() {	19 function test() {

26 var div = document.createElement('div');	20 var div = document.createElement('div');

27 var input = document.createElement('input');	21 var input = document.createElement('input');

28 input.setAttribute('form', 'foo');	22 input.setAttribute('form', 'foo');

29 div.appendChild(input);	23 div.appendChild(input);

30 setTimeout(resetFormOwner, 0);	24 setTimeout(resetFormOwner, 0);

31 }	25 }

32 </script>	26 </script>

33 <body onload="test()">	27 <body onload="test()">

34 <p>Checks dangling form associated elements doesn't cause crash. WebKit should n ot crash when this page is loaded.</p>	28 <p>Checks dangling form associated elements doesn't cause crash. WebKit should n ot crash when this page is loaded.</p>

35 </body>	29 </body>

36 </html>	30 </html>

OLD	NEW