Android: Remove GetApplicationContext part 4

Android: Remove GetApplicationContext part 4

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

Part 1: https://codereview.chromium.org/2772343003/
Part 2: https://codereview.chromium.org/2799263002/
Part 2.1 (cast): http://crrev.com/2807263002
Part 2.2 (components): http://crrev.com/2810863003
Part 3: http://crrev.com/2828353002

BUG=646094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2847523002
Cr-Commit-Position: refs/heads/master@{#471861}
Committed: https://chromium.googlesource.com/chromium/src/+/da737c56165f6fae6e81c488cf5821b7a77c7d1d

[Peter Wen, 2017-04-26 20:34:08]

Description was changed from

==========
Android: Remove GetApplicationContext part 4

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

Part 1: https://codereview.chromium.org/2772343003/
Part 2: https://codereview.chromium.org/2799263002/
Part 2.1 (cast): http://crrev.com/2807263002
Part 2.2 (components): http://crrev.com/2810863003
Part 3: http://crrev.com/2828353002

BUG=646094
==========

to

==========
Android: Remove GetApplicationContext part 4

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

Part 1: https://codereview.chromium.org/2772343003/
Part 2: https://codereview.chromium.org/2799263002/
Part 2.1 (cast): http://crrev.com/2807263002
Part 2.2 (components): http://crrev.com/2810863003
Part 3: http://crrev.com/2828353002

BUG=646094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Peter Wen, 2017-04-26 20:34:09]

Description was changed from

==========
Android: Remove GetApplicationContext part 4

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

Part 1: https://codereview.chromium.org/2772343003/
Part 2: https://codereview.chromium.org/2799263002/
Part 2.1 (cast): http://crrev.com/2807263002
Part 2.2 (components): http://crrev.com/2810863003
Part 3: http://crrev.com/2828353002

BUG=646094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Android: Remove GetApplicationContext part 4

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

Part 1: https://codereview.chromium.org/2772343003/
Part 2: https://codereview.chromium.org/2799263002/
Part 2.1 (cast): http://crrev.com/2807263002
Part 2.2 (components): http://crrev.com/2810863003
Part 3: http://crrev.com/2828353002

BUG=646094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Peter Wen, 2017-04-26 20:34:50]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 20:35:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 21:19:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 21:19:10]

Dry run: Try jobs failed on following builders:
  android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Peter Wen, 2017-04-27 15:09:29]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 15:10:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 16:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 16:03:51]

Dry run: Try jobs failed on following builders:
  android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Peter Wen, 2017-04-27 19:40:34]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 19:41:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 19:57:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:57:50]

Dry run: Try jobs failed on following builders:
  android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Peter Wen, 2017-05-04 12:21:05]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 12:21:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 12:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 12:41:37]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Peter Wen, 2017-05-04 12:52:28]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 12:52:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-05-04 14:07:37]

wnwen@chromium.org changed reviewers:
+ agrieve@chromium.org

[Peter Wen, 2017-05-04 14:07:39]

Hopefully the last upstream one! ⌛

[mthiesse, 2017-05-04 14:30:06]

mthiesse@chromium.org changed reviewers:
+ mthiesse@chromium.org

[mthiesse, 2017-05-04 14:30:07]

https://codereview.chromium.org/2847523002/diff/80001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device_provider.cc (right):

https://codereview.chromium.org/2847523002/diff/80001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device_provider.cc:7: #include <jni.h>
This looks unintentional, did you mean to add these headers here? We shouldn't
need any of these.

[Peter Wen, 2017-05-04 14:36:10]

https://codereview.chromium.org/2847523002/diff/80001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device_provider.cc (right):

https://codereview.chromium.org/2847523002/diff/80001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device_provider.cc:7: #include <jni.h>
On 2017/05/04 14:30:07, mthiesse wrote:
> This looks unintentional, did you mean to add these headers here? We shouldn't
> need any of these.

Thanks, not sure how these got here.

[agrieve, 2017-05-04 15:55:50]

Only one real concern about a cast. Also - why the added test?

https://codereview.chromium.org/2847523002/diff/80001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
(right):

https://codereview.chromium.org/2847523002/diff/80001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java:37:
mActivity = new Activity();
unused?

https://codereview.chromium.org/2847523002/diff/80001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device_provider.cc (right):

https://codereview.chromium.org/2847523002/diff/80001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device_provider.cc:7: #include <jni.h>
Are these really newly required?

https://codereview.chromium.org/2847523002/diff/80001/services/device/vibrati...
File
services/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
(right):

https://codereview.chromium.org/2847523002/diff/80001/services/device/vibrati...
services/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java:86:
public Factory() {}
nit: delete.

https://codereview.chromium.org/2847523002/diff/80001/ui/platform_window/andr...
File
ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java
(right):

https://codereview.chromium.org/2847523002/diff/80001/ui/platform_window/andr...
ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java:35:
((Activity) ContextUtils.getApplicationContext()).setContentView(rv);
You're casting the application context to an Activity. I don't think that's
going to work.

[Peter Wen, 2017-05-04 17:39:26]

Thanks! PTAL, no rush.

https://codereview.chromium.org/2847523002/diff/80001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
(right):

https://codereview.chromium.org/2847523002/diff/80001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java:37:
mActivity = new Activity();
On 2017/05/04 15:55:50, agrieve wrote:
> unused?

Opps, this was moved in a rebase.

https://codereview.chromium.org/2847523002/diff/80001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device_provider.cc (right):

https://codereview.chromium.org/2847523002/diff/80001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device_provider.cc:7: #include <jni.h>
On 2017/05/04 15:55:50, agrieve wrote:
> Are these really newly required?

Removed.

https://codereview.chromium.org/2847523002/diff/80001/services/device/vibrati...
File
services/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
(right):

https://codereview.chromium.org/2847523002/diff/80001/services/device/vibrati...
services/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java:86:
public Factory() {}
On 2017/05/04 15:55:50, agrieve wrote:
> nit: delete.

Done.

https://codereview.chromium.org/2847523002/diff/80001/ui/platform_window/andr...
File
ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java
(right):

https://codereview.chromium.org/2847523002/diff/80001/ui/platform_window/andr...
ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java:35:
((Activity) ContextUtils.getApplicationContext()).setContentView(rv);
On 2017/05/04 15:55:50, agrieve wrote:
> You're casting the application context to an Activity. I don't think that's
> going to work.

Maybe this is actually never called, but native does actually call
Java_PlatformWindowAndroid_createForActivity with the application context as an
activity.

[agrieve, 2017-05-04 18:24:51]

lgtm

https://codereview.chromium.org/2847523002/diff/80001/ui/platform_window/andr...
File
ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java
(right):

https://codereview.chromium.org/2847523002/diff/80001/ui/platform_window/andr...
ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java:35:
((Activity) ContextUtils.getApplicationContext()).setContentView(rv);
On 2017/05/04 17:39:26, Peter Wen wrote:
> On 2017/05/04 15:55:50, agrieve wrote:
> > You're casting the application context to an Activity. I don't think that's
> > going to work.
> 
> Maybe this is actually never called, but native does actually call
> Java_PlatformWindowAndroid_createForActivity with the application context as
an
> activity.

aha. Did some codesearching and my best guess is that this is part of the
never-finished Android aura port. Likely never called :/.

[Peter Wen, 2017-05-04 18:37:40]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 18:38:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-05-04 18:38:31]

wnwen@chromium.org changed reviewers:
+ brettw@chromium.org

[Peter Wen, 2017-05-04 18:38:32]

Thanks Andrew!

+brettw@ for global OWNERS. This is hopefully the last CL finishing this
refactoring.

[commit-bot: I haz the power, 2017-05-04 18:44:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 18:44:04]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Peter Wen, 2017-05-04 19:05:24]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 19:05:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-05-04 20:39:33]

wnwen@chromium.org changed reviewers:
+ miguelg@chromium.org

[Peter Wen, 2017-05-04 20:39:35]

+miguelg@ for infobar OWNERS

[commit-bot: I haz the power, 2017-05-04 20:47:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 20:47:55]

Dry run: This issue passed the CQ dry run.

[Miguel Garcia, 2017-05-05 09:58:50]

lgtm for infobar

[Peter Wen, 2017-05-08 14:32:23]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 14:32:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 14:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 14:59:19]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Peter Wen, 2017-05-08 15:32:33]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 15:33:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-05-08 17:11:12]

Friendly ping for global OWNERS. Thanks!

[commit-bot: I haz the power, 2017-05-08 18:06:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:06:11]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-05-09 22:58:25]

rs lgtm

[Peter Wen, 2017-05-10 13:41:58]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 13:42:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 14:55:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 14:55:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Wen, 2017-05-10 17:16:03]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-05-10 17:16:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
agrieve@chromium.org, miguelg@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2847523002/#ps220001
(title: "Fix test.")

[commit-bot: I haz the power, 2017-05-10 17:17:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:56:18]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2017-05-10 20:40:18]

scheib@chromium.org changed reviewers:
+ scheib@chromium.org

[scheib, 2017-05-10 20:40:20]

While things compile and tests pass, removing context from the wrapper/fakes
goes against their design to wrap the Android APIs with minimal/no changes.

https://codereview.chromium.org/2847523002/diff/220001/device/bluetooth/andro...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java
(right):

https://codereview.chromium.org/2847523002/diff/220001/device/bluetooth/andro...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java:109:
mBluetoothGatt = mDevice.connectGatt(false /* autoConnect */,
mBluetoothGattCallbackImpl,
mDevice.connectGatt(ContextUtils.getApplicationContext(), ...

https://codereview.chromium.org/2847523002/diff/220001/device/bluetooth/andro...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java
(right):

https://codereview.chromium.org/2847523002/diff/220001/device/bluetooth/andro...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java:323:
public BluetoothGattWrapper connectGatt(
This method should preserve the Android SDK signature of 
android.bluetooth.BluetoothDevice:

 connectGatt(Context context, boolean autoConnect...

[Peter Wen, 2017-05-11 14:01:34]

Thank you Vincent! Fixed now.

https://codereview.chromium.org/2847523002/diff/220001/device/bluetooth/andro...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java
(right):

https://codereview.chromium.org/2847523002/diff/220001/device/bluetooth/andro...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java:109:
mBluetoothGatt = mDevice.connectGatt(false /* autoConnect */,
mBluetoothGattCallbackImpl,
On 2017/05/10 20:40:20, scheib wrote:
> mDevice.connectGatt(ContextUtils.getApplicationContext(), ...

Done.

https://codereview.chromium.org/2847523002/diff/220001/device/bluetooth/andro...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java
(right):

https://codereview.chromium.org/2847523002/diff/220001/device/bluetooth/andro...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java:323:
public BluetoothGattWrapper connectGatt(
On 2017/05/10 20:40:20, scheib wrote:
> This method should preserve the Android SDK signature of 
> android.bluetooth.BluetoothDevice:
> 
>  connectGatt(Context context, boolean autoConnect...

Done.

[Peter Wen, 2017-05-11 14:02:03]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-05-11 14:02:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
miguelg@chromium.org, agrieve@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2847523002/#ps240001
(title: "Rebase and fix wrappers")

[commit-bot: I haz the power, 2017-05-11 14:02:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 14:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 14:35:31]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Peter Wen, 2017-05-11 14:53:59]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 14:54:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 16:13:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 16:13:40]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Peter Wen, 2017-05-11 16:18:51]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-05-11 16:18:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
miguelg@chromium.org, agrieve@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2847523002/#ps260001
(title: "Fix fakes")

[commit-bot: I haz the power, 2017-05-11 16:19:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2017-05-11 18:18:07]

lgtm

[commit-bot: I haz the power, 2017-05-11 19:09:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 19:09:59]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Wen, 2017-05-11 19:19:44]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2017-05-11 19:20:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 22:25:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 22:25:52]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Wen, 2017-05-15 11:44:48]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 11:45:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 12:30:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 12:30:04]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Peter Wen, 2017-05-15 13:22:14]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-05-15 13:22:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
miguelg@chromium.org, scheib@chromium.org, agrieve@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2847523002/#ps280001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-15 13:22:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 13:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 13:33:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Wen, 2017-05-15 13:43:43]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-05-15 13:43:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
miguelg@chromium.org, scheib@chromium.org, agrieve@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2847523002/#ps300001
(title: "Rebase again")

[commit-bot: I haz the power, 2017-05-15 13:44:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 14:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 14:12:03]

Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

[Peter Wen, 2017-05-15 14:20:41]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-05-15 14:20:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
miguelg@chromium.org, scheib@chromium.org, agrieve@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2847523002/#ps320001
(title: "Remove new introduction of header")

[commit-bot: I haz the power, 2017-05-15 14:21:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 14:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 14:49:24]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

[Peter Wen, 2017-05-15 15:02:20]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-05-15 15:02:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
miguelg@chromium.org, scheib@chromium.org, agrieve@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2847523002/#ps340001
(title: "Fix build")

[commit-bot: I haz the power, 2017-05-15 15:03:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 15:09:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 15:09:46]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Wen, 2017-05-15 15:37:10]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-05-15 15:37:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
miguelg@chromium.org, scheib@chromium.org, agrieve@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2847523002/#ps360001
(title: "Another rebase")

[commit-bot: I haz the power, 2017-05-15 15:38:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 16:04:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 16:05:03]

Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

[Peter Wen, 2017-05-15 17:01:03]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-05-15 17:01:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
miguelg@chromium.org, scheib@chromium.org, agrieve@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2847523002/#ps380001
(title: "Rebase and fix build")

[commit-bot: I haz the power, 2017-05-15 17:01:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 19:29:19]

CQ is committing da patch.

Bot data: {"patchset_id": 380001, "attempt_start_ts": 1494867663199460,
"parent_rev": "57bb4b6713175b902e2c4e19df6df3872d69e885", "commit_rev":
"da737c56165f6fae6e81c488cf5821b7a77c7d1d"}

[commit-bot: I haz the power, 2017-05-15 19:29:30]

Description was changed from

==========
Android: Remove GetApplicationContext part 4

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

Part 1: https://codereview.chromium.org/2772343003/
Part 2: https://codereview.chromium.org/2799263002/
Part 2.1 (cast): http://crrev.com/2807263002
Part 2.2 (components): http://crrev.com/2810863003
Part 3: http://crrev.com/2828353002

BUG=646094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Android: Remove GetApplicationContext part 4

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

Part 1: https://codereview.chromium.org/2772343003/
Part 2: https://codereview.chromium.org/2799263002/
Part 2.1 (cast): http://crrev.com/2807263002
Part 2.2 (components): http://crrev.com/2810863003
Part 3: http://crrev.com/2828353002

BUG=646094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2847523002
Cr-Commit-Position: refs/heads/master@{#471861}
Committed:
https://chromium.googlesource.com/chromium/src/+/da737c56165f6fae6e81c488cf58...
==========

[commit-bot: I haz the power, 2017-05-15 19:29:33]

Committed patchset #20 (id:380001) as
https://chromium.googlesource.com/chromium/src/+/da737c56165f6fae6e81c488cf58...