chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java - Issue 2847523002: Android: Remove GetApplicationContext part 4

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

Issue 2847523002: Android: Remove GetApplicationContext part 4 (Closed)

Patch Set: Rebase and fix build Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

index 406da19059535cfcdfc6600a431703f7ad817711..ef72ff644e473cf39c0985f181120e4e39fb39f1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

@@ -161,7 +161,7 @@ public class BookmarkUtils {

if (activity.getBottomSheet() != null) {

activity.getBottomSheetContentController().showContentAndOpenSheet(

R.id.action_bookmarks);

- } else if (DeviceFormFactor.isTablet(activity)) {

+ } else if (DeviceFormFactor.isTablet()) {

openUrl(activity, url, activity.getComponentName());

} else {

Intent intent = new Intent(activity, BookmarkActivity.class);

@@ -247,7 +247,7 @@ public class BookmarkUtils {

RecordHistogram.recordEnumeratedHistogram(

"Stars.LaunchLocation", launchLocation, BookmarkLaunchLocation.COUNT);

- if (DeviceFormFactor.isTablet(activity)) {

+ if (DeviceFormFactor.isTablet()) {

// For tablets, the bookmark manager is open in a tab in the ChromeActivity. Use

// the ComponentName of the ChromeActivity passed into this method.

openUrl(activity, url, activity.getComponentName());