Android: Remove GetApplicationContext part 1

Android: Remove GetApplicationContext part 1

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

BUG=646094
Review-Url: https://codereview.chromium.org/2772343003
Cr-Commit-Position: refs/heads/master@{#460458}
Committed: https://chromium.googlesource.com/chromium/src/+/321152dcf0906133028c0e50559b8e5101260b48

[Peter Wen, 2017-03-27 20:01:37]

wnwen@chromium.org changed reviewers:
+ estevenson@chromium.org

[Peter Wen, 2017-03-27 20:01:38]

PTAL :)

[estevenson, 2017-03-27 21:00:54]

[meaningless] lgtm :)

https://codereview.chromium.org/2772343003/diff/1/base/android/apk_assets.cc
File base/android/apk_assets.cc (right):

https://codereview.chromium.org/2772343003/diff/1/base/android/apk_assets.cc#...
base/android/apk_assets.cc:9: #include "base/android/context_utils.h"
nit: should be able to get rid of this import now (other files as well).

https://codereview.chromium.org/2772343003/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java (right):

https://codereview.chromium.org/2772343003/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:622: public
static Uri getUriForImageCaptureFile(Context context, File file) {
nit: remove the context param as well while you're here?

https://codereview.chromium.org/2772343003/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/BuildInfo.java (right):

https://codereview.chromium.org/2772343003/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/BuildInfo.java:84: PackageManager pm =
ContextUtils.getApplicationContext().getPackageManager();
optional nit: might be a little nicer to store context here instead of making
two calls to ContextUtils.getApplicationContext()?

[Peter Wen, 2017-03-27 22:31:07]

Thanks for the review! Appreciate it, always good to have a second pair of eyes.

https://codereview.chromium.org/2772343003/diff/1/base/android/apk_assets.cc
File base/android/apk_assets.cc (right):

https://codereview.chromium.org/2772343003/diff/1/base/android/apk_assets.cc#...
base/android/apk_assets.cc:9: #include "base/android/context_utils.h"
On 2017/03/27 21:00:54, estevenson wrote:
> nit: should be able to get rid of this import now (other files as well).

Nice catch!

https://codereview.chromium.org/2772343003/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java (right):

https://codereview.chromium.org/2772343003/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:622: public
static Uri getUriForImageCaptureFile(Context context, File file) {
On 2017/03/27 21:00:54, estevenson wrote:
> nit: remove the context param as well while you're here?

Done.

https://codereview.chromium.org/2772343003/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/BuildInfo.java (right):

https://codereview.chromium.org/2772343003/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/BuildInfo.java:84: PackageManager pm =
ContextUtils.getApplicationContext().getPackageManager();
On 2017/03/27 21:00:54, estevenson wrote:
> optional nit: might be a little nicer to store context here instead of making
> two calls to ContextUtils.getApplicationContext()?

Modified it a little bit by calling getPackageName() locally. Proguard will
optimize away ContextUtils, so I'd prefer to use it directly where it is
required, but short hands are good when it's used a lot.

Might think about renaming to ContextUtils.getAppContext() instead.

[Peter Wen, 2017-03-27 22:33:53]

wnwen@chromium.org changed reviewers:
+ tedchoc@chromium.org, torne@chromium.org

[Peter Wen, 2017-03-27 22:33:54]

+torne@ for base/ OWNERS
+tedchoc@ for chrome/android, chrome/browser, ui/ OWNERS

If this CL is good then I will gradually go through and remove the rest of
base::android::GetApplicationContext(). No need to pass a global pointer from
java to native back to java.

[Peter Wen, 2017-03-27 22:35:05]

wnwen@chromium.org changed reviewers:
+ twellington@chromium.org

[Peter Wen, 2017-03-27 22:35:06]

+twellington@ for download/ui OWNERS

[Torne, 2017-03-28 13:10:08]

base LGTM

[Ted C, 2017-03-28 15:53:41]

lgtm

[Theresa, 2017-03-28 16:33:30]

download/ui/ lgtm

[Peter Wen, 2017-03-29 13:09:33]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 13:09:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 13:12:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 13:12:18]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Peter Wen, 2017-03-29 15:18:46]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 15:19:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-03-29 16:08:50]

The CQ bit was unchecked by wnwen@chromium.org

[Peter Wen, 2017-03-29 16:08:54]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-03-29 16:08:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org, tedchoc@chromium.org, twellington@chromium.org,
torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2772343003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-29 16:09:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 16:09:15]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2017-03-29 18:02:04]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2017-03-29 18:03:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 18:09:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490810524946520,
"parent_rev": "2d7baa9276da1713abbbb01cf8b28065292302ff", "commit_rev":
"7d23afaa43a7b0cf2f85630af5e524e22dbed511"}

[commit-bot: I haz the power, 2017-03-29 18:14:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490810524946520,
"parent_rev": "44c19b6cb6df770a69ab7198495be971583ddc9c", "commit_rev":
"321152dcf0906133028c0e50559b8e5101260b48"}

[commit-bot: I haz the power, 2017-03-29 18:16:28]

Description was changed from

==========
Android: Remove GetApplicationContext part 1

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

BUG=646094
==========

to

==========
Android: Remove GetApplicationContext part 1

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

BUG=646094

Review-Url: https://codereview.chromium.org/2772343003
Cr-Commit-Position: refs/heads/master@{#460458}
Committed:
https://chromium.googlesource.com/chromium/src/+/321152dcf0906133028c0e50559b...
==========

[commit-bot: I haz the power, 2017-03-29 18:16:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/321152dcf0906133028c0e50559b...