Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2847173004: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, skanuj+watch_chromium.org, rogerm+autofillwatch_chromium.org, dcheng, jdonnelly+watch_chromium.org, melevin+watch_chromium.org, sebsg+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jfweitz+watch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, dbeam+watch-downloads_chromium.org, Jered, David Trainor- moved to gerrit, mathp+autofillwatch_chromium.org, tfarina, donnd+watch_chromium.org, David Black, samarth+watch_chromium.org, mac-reviews_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2847173004 Cr-Commit-Position: refs/heads/master@{#468535} Committed: https://chromium.googlesource.com/chromium/src/+/e8937a55f7f21754924801c7b376c242d0722d01

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -29 lines) Patch
M chrome/browser/ui/autofill/save_card_bubble_controller_impl.h View 2 chunks +2 lines, -1 line 2 comments Download
M chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_tab_restorer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_within_tab_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_stats_recorder.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_feedback_dialog_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_dialogs_views.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-29 02:24:56 UTC) #6
Avi (use Gerrit)
3 years, 7 months ago (2017-04-29 02:25:43 UTC) #8
sky
LGTM https://codereview.chromium.org/2847173004/diff/1/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h File chrome/browser/ui/autofill/save_card_bubble_controller_impl.h (right): https://codereview.chromium.org/2847173004/diff/1/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h#newcode28 chrome/browser/ui/autofill/save_card_bubble_controller_impl.h:28: ~SaveCardBubbleControllerImpl() override; Move definition to match new position? ...
3 years, 7 months ago (2017-05-01 17:34:27 UTC) #9
Avi (use Gerrit)
https://codereview.chromium.org/2847173004/diff/1/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h File chrome/browser/ui/autofill/save_card_bubble_controller_impl.h (right): https://codereview.chromium.org/2847173004/diff/1/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h#newcode28 chrome/browser/ui/autofill/save_card_bubble_controller_impl.h:28: ~SaveCardBubbleControllerImpl() override; On 2017/05/01 17:34:27, sky wrote: > Move ...
3 years, 7 months ago (2017-05-02 01:31:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847173004/1
3 years, 7 months ago (2017-05-02 01:31:53 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 02:17:40 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8937a55f7f21754924801c7b376...

Powered by Google App Engine
This is Rietveld 408576698