Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 2847173004: Switch SupportsUserData uses to use unique_ptr. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
index ada02e2276af50128a942a2c04429ad8b3b0dbcd..05dd79f60aa29b9f2c517163933ed491ae3fa921 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
@@ -121,8 +121,8 @@ struct OmniboxViewMacState : public base::SupportsUserData::Data {
// Accessors for storing and getting the state from the tab.
void StoreStateToTab(WebContents* tab,
- OmniboxViewMacState* state) {
- tab->SetUserData(kOmniboxViewMacStateKey, state);
+ std::unique_ptr<OmniboxViewMacState> state) {
+ tab->SetUserData(kOmniboxViewMacStateKey, std::move(state));
}
const OmniboxViewMacState* GetStateFromTab(const WebContents* tab) {
@@ -222,9 +222,8 @@ void OmniboxViewMac::SaveStateToTab(WebContents* tab) {
range = NSMakeRange(0, GetTextLength());
}
- OmniboxViewMacState* state =
- new OmniboxViewMacState(model()->GetStateForTabSwitch(), hasFocus, range);
- StoreStateToTab(tab, state);
+ StoreStateToTab(tab, base::MakeUnique<OmniboxViewMacState>(
+ model()->GetStateForTabSwitch(), hasFocus, range));
}
void OmniboxViewMac::OnTabChanged(const WebContents* web_contents) {

Powered by Google App Engine
This is Rietveld 408576698