chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc - Issue 2847173004: Switch SupportsUserData uses to use unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

Issue 2847173004: Switch SupportsUserData uses to use unique_ptr. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/save_card_bubble_controller_impl.h ('K') | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | chrome/browser/ui/views/tab_dialogs_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc b/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

index fc6b2e90c7c023e6ed7d62ed26ff6e477b89ac8a..0d4c7d571998ab3f64d0c60ec0f0f995dbcf73db 100644

--- a/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

@@ -115,7 +115,7 @@ TestManagePasswordsUIController::TestManagePasswordsUIController(

// Do not silently replace an existing ManagePasswordsUIController because it

// unregisters itself in WebContentsDestroyed().

EXPECT_FALSE(web_contents->GetUserData(UserDataKey()));

- web_contents->SetUserData(UserDataKey(), this);

+ web_contents->SetUserData(UserDataKey(), base::WrapUnique(this));

}

void TestManagePasswordsUIController::OnDialogHidden() {