Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2847003005: Reland "Add enable_ipc_logging build argument" (Closed)

Created:
3 years, 7 months ago by Szabolcs David
Modified:
3 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Add enable_ipc_logging build argument" It caused a build flake due to incorrect dependents on //ipc and it was reverted. Fixes committed in order to fix these: - https://codereview.chromium.org/2767193005 - https://codereview.chromium.org/2852273002 > Implement a build option to enable the IPC logging system > in release builds. It's useful to save time and resources when > debugging IPC communication (e.g. in automated testing > environments). > > It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag. BUG= Review-Url: https://codereview.chromium.org/2847003005 Cr-Commit-Position: refs/heads/master@{#471255} Committed: https://chromium.googlesource.com/chromium/src/+/041528ae6e6abe67ac2f5c14cd4991b8e181ecf2

Patch Set 1 #

Patch Set 2 : Reland "Add enable_ipc_logging build argument" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -64 lines) Patch
M chrome/common/logging_chrome.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_ipc_logging.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M content/common/child_process_host_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/child_process_messages.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/content_ipc_logging.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/public/browser/browser_ipc_logging.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_ipc_logging.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_logging.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_logging.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_message.h View 3 chunks +3 lines, -6 lines 0 comments Download
M ipc/ipc_message.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/nacl_irt/irt_ppapi.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Szabolcs David
3 years, 7 months ago (2017-05-10 09:12:19 UTC) #11
jam
rs lgtm
3 years, 7 months ago (2017-05-10 16:11:45 UTC) #12
Ken Rockot(use gerrit already)
LGTM If adding multiple reviewers to a CL , please indicate which parts you'd like ...
3 years, 7 months ago (2017-05-11 15:34:32 UTC) #13
kenrb
lgtm
3 years, 7 months ago (2017-05-11 15:36:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847003005/20001
3 years, 7 months ago (2017-05-11 15:37:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/442034)
3 years, 7 months ago (2017-05-11 18:00:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847003005/20001
3 years, 7 months ago (2017-05-12 08:15:11 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 09:19:43 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/041528ae6e6abe67ac2f5c14cd49...

Powered by Google App Engine
This is Rietveld 408576698