Make extensions/browser/api/* sources to publicly depend on //ipc

Make extensions/browser/api/* sources to publicly depend on //ipc

Several //ipc headers will depend on a generated buildflag header and
we have to guarantee the existence of this header before the build of
these source sets.

BUG=711302
Review-Url: https://codereview.chromium.org/2852273002
Cr-Commit-Position: refs/heads/master@{#469232}
Committed: https://chromium.googlesource.com/chromium/src/+/3c2d1c61befedf006810b4e9d663d6dfae602eeb

[Szabolcs David, 2017-05-02 08:51:10]

Description was changed from

==========
Make extensions/browser/api/* sources to publicly depend on //ipc

Several //ipc headers will depend on a generated buildflag header and
we have to guarantee the existence of this header before the build of
these source sets.

BUG=711302
==========

to

==========
Make extensions/browser/api/* sources to publicly depend on //ipc

Several //ipc headers will depend on a generated buildflag header and
we have to guarantee the existence of this header before the build of
these source sets.

BUG=711302
==========

[Szabolcs David, 2017-05-02 08:51:10]

davidsz@inf.u-szeged.hu changed reviewers:
+ benwells@chromium.org, rockot@chromium.org

[Szabolcs David, 2017-05-02 08:53:32]

See these error messages:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux...

[Ken Rockot(use gerrit already), 2017-05-02 16:41:47]

Hmm, this looks wrong.

The problem here seems to be that //ipc is a public dependency of
//extensions/browser:browser_sources (and this is properly expressed in GN), but
the browser API impls do not in turn express their public dependency on
//extensions/browser:browser_sources.

Is it not possible to add //extensions/browser:browser_sources to the
public_deps of each API target under //extensions/browser/api/foo? I don't think
it will result in any circular dependency issues.

https://codereview.chromium.org/2852273002/diff/1/extensions/common/api/BUILD.gn
File extensions/common/api/BUILD.gn (right):

https://codereview.chromium.org/2852273002/diff/1/extensions/common/api/BUILD...
extensions/common/api/BUILD.gn:39: "//ipc",
This is not actually a dependency of anything here. Please don't add it to this
target.

[Szabolcs David, 2017-05-03 14:47:59]

On 2017/05/02 16:41:47, Ken Rockot wrote:
> Hmm, this looks wrong.
> 
> The problem here seems to be that //ipc is a public dependency of
> //extensions/browser:browser_sources (and this is properly expressed in GN),
but
> the browser API impls do not in turn express their public dependency on
> //extensions/browser:browser_sources.
> 
> Is it not possible to add //extensions/browser:browser_sources to the
> public_deps of each API target under //extensions/browser/api/foo? I don't
think
> it will result in any circular dependency issues.
> 
>
https://codereview.chromium.org/2852273002/diff/1/extensions/common/api/BUILD.gn
> File extensions/common/api/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2852273002/diff/1/extensions/common/api/BUILD...
> extensions/common/api/BUILD.gn:39: "//ipc",
> This is not actually a dependency of anything here. Please don't add it to
this
> target.

You are right, it looks better.

[Ken Rockot(use gerrit already), 2017-05-03 15:02:15]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 15:02:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 16:07:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 16:07:37]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-05-03 16:16:32]

Thanks, LGTM!

[benwells, 2017-05-04 01:13:38]

as you've already got Ken's lg you don't need mind; feel free to land.

[Ken Rockot(use gerrit already), 2017-05-04 01:20:22]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-05-04 01:20:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 01:26:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493860822043740,
"parent_rev": "ffc595bc81b4a23043061b5b34c66c8a4ab06612", "commit_rev":
"3c2d1c61befedf006810b4e9d663d6dfae602eeb"}

[commit-bot: I haz the power, 2017-05-04 01:27:09]

Description was changed from

==========
Make extensions/browser/api/* sources to publicly depend on //ipc

Several //ipc headers will depend on a generated buildflag header and
we have to guarantee the existence of this header before the build of
these source sets.

BUG=711302
==========

to

==========
Make extensions/browser/api/* sources to publicly depend on //ipc

Several //ipc headers will depend on a generated buildflag header and
we have to guarantee the existence of this header before the build of
these source sets.

BUG=711302

Review-Url: https://codereview.chromium.org/2852273002
Cr-Commit-Position: refs/heads/master@{#469232}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c2d1c61befedf006810b4e9d663...
==========

[commit-bot: I haz the power, 2017-05-04 01:27:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3c2d1c61befedf006810b4e9d663...