Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(66)

Issue 2846933002: Use ScopedTaskEnvironment instead of MessageLoopForUI in content tests. (Closed)

Created:
2 years, 5 months ago by fdoray
Modified:
2 years, 5 months ago
Reviewers:
emircan, gab, tdresser
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, emircan+watch+mediarecorder_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, mcasas+capturefromelement_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, emircan+watch+capturefromdom_chromium.org, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, mcasas+mediarecorder_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoopForUI in content tests. ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in everytest that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 R=gab@chromium.org TBR=emircan@chromium.org, tdresser@chromium.org Review-Url: https://codereview.chromium.org/2846933002 Cr-Commit-Position: refs/heads/master@{#468368} Committed: https://chromium.googlesource.com/chromium/src/+/8f9f016285a1178e63e8676ecc950db84a92cc65

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -39 lines) Patch
M content/browser/renderer_host/input/gesture_event_queue_unittest.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_perftest.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/legacy_touch_event_queue_unittest.cc View 1 4 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc View 1 4 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_video_capturer_source_unittest.cc View 1 5 chunks +9 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_video_source_unittest.cc View 1 5 chunks +9 lines, -5 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_video_webrtc_sink_unittest.cc View 1 5 chunks +9 lines, -4 lines 0 comments Download
M content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/media_recorder/media_recorder_handler_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
fdoray
2 years, 5 months ago (2017-04-27 18:30:37 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
2 years, 5 months ago (2017-04-27 18:30:40 UTC) #3
emircan
content/renderer/* lgtm
2 years, 5 months ago (2017-04-27 22:16:08 UTC) #11
gab
content/browser lgtm
2 years, 5 months ago (2017-05-01 18:16:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846933002/20001
2 years, 5 months ago (2017-05-01 18:16:59 UTC) #18
commit-bot: I haz the power
2 years, 5 months ago (2017-05-01 18:47:47 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8f9f016285a1178e63e8676ecc95...

Powered by Google App Engine
This is Rietveld 408576698