Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9055)

Unified Diff: content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc

Issue 2846933002: Use ScopedTaskEnvironment instead of MessageLoopForUI in content tests. (Closed)
Patch Set: self-review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
diff --git a/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc b/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
index 5df6e0204cdf2d3539e047b3f84706d8d63927e5..9d88e2a28ef8a139a32d445d7cdeeb0e4cb51005 100644
--- a/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
+++ b/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
@@ -13,6 +13,7 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
+#include "base/test/scoped_task_environment.h"
#include "base/threading/thread_task_runner_handle.h"
#include "content/browser/renderer_host/input/timeout_monitor.h"
#include "content/common/input/synthetic_web_input_event_builders.h"
@@ -140,7 +141,9 @@ class MouseWheelEventQueueTest : public testing::TestWithParam<bool>,
public MouseWheelEventQueueClient {
public:
MouseWheelEventQueueTest()
- : acked_event_count_(0),
+ : scoped_task_environment_(
+ base::test::ScopedTaskEnvironment::MainThreadType::UI),
+ acked_event_count_(0),
last_acked_event_state_(INPUT_EVENT_ACK_STATE_UNKNOWN) {
scroll_latching_enabled_ = GetParam();
queue_.reset(new MouseWheelEventQueue(this, scroll_latching_enabled_));
@@ -444,11 +447,11 @@ class MouseWheelEventQueueTest : public testing::TestWithParam<bool>,
}
}
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
std::unique_ptr<MouseWheelEventQueue> queue_;
std::vector<std::unique_ptr<WebInputEvent>> sent_events_;
size_t acked_event_count_;
InputEventAckState last_acked_event_state_;
- base::MessageLoopForUI message_loop_;
WebMouseWheelEvent last_acked_event_;
int64_t scroll_end_timeout_ms_;
bool scroll_latching_enabled_;

Powered by Google App Engine
This is Rietveld 408576698