Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc

Issue 2846933002: Use ScopedTaskEnvironment instead of MessageLoopForUI in content tests. (Closed)
Patch Set: self-review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc
diff --git a/content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc b/content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc
index 6e3d0c195167923886cd34c4ddecd7c490daf1f5..ae59795e10731b428845d308cbd85ee6f9e9091b 100644
--- a/content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc
+++ b/content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc
@@ -14,6 +14,7 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
+#include "base/test/scoped_task_environment.h"
#include "base/threading/thread_task_runner_handle.h"
#include "content/browser/renderer_host/input/timeout_monitor.h"
#include "content/common/input/synthetic_web_input_event_builders.h"
@@ -43,7 +44,9 @@ class PassthroughTouchEventQueueTest : public testing::Test,
public TouchEventQueueClient {
public:
PassthroughTouchEventQueueTest()
- : acked_event_count_(0),
+ : scoped_task_environment_(
+ base::test::ScopedTaskEnvironment::MainThreadType::UI),
+ acked_event_count_(0),
last_acked_event_state_(INPUT_EVENT_ACK_STATE_UNKNOWN),
slop_length_dips_(0) {}
@@ -324,6 +327,7 @@ class PassthroughTouchEventQueueTest : public testing::Test,
queue_->OnHasTouchEventHandlers(true);
}
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
std::unique_ptr<PassthroughTouchEventQueue> queue_;
size_t acked_event_count_;
WebTouchEvent last_acked_event_;
@@ -335,7 +339,6 @@ class PassthroughTouchEventQueueTest : public testing::Test,
std::unique_ptr<InputEventAckState> sync_ack_result_;
double slop_length_dips_;
gfx::PointF anchor_;
- base::MessageLoopForUI message_loop_;
std::deque<int> sent_events_ids_;
};

Powered by Google App Engine
This is Rietveld 408576698