Removed local RefPtr created from PassRefPtr arg in generated file.

Removed local RefPtr created from PassRefPtr arg in generated file.

This is a follow up from https://codereview.chromium.org/2807073002

This patch removed a generated instance of a PassRefPtr object being
copied into a RefPtr object.

All instances of PassRefPtr objects being copied into RefPtr objects
need to be wrapped in std::move to avoid introducing ref churn in
future changes when all PassRefPtr objects will be replaced with RefPtr
objects. In this case creating a local RefPtr just to copy the
PassRefPtr argument into, a std::move wrap doesn't make sense as it
would result in a final state where a RefPtr argument is moved into a
local RefPtr for no reason. So to handle this cases I have converted
the PassRefPtr argument to RefPtr in advance, and removed the local
RefPtr argument, instead using the passed RefPtr in the
method.

This patch
- Changed the argument passed from PassRefPtr to RefPtr
- Removed the logic for creating a local RefPtr argument
- Changed the naming logic to name RefPtr arguments as rpParamTypeName
- Removed the self.value variable and used self.name instead, as
  self.value was only used to store the name of the local RefPtr
  variable separate from the PassRefPtr argument
- Removed the comment in the header about PassRefPtr parameters
- Removed the base_name variable in build_param_name as this was
  causing a presubmit error from clashing with the global base_name

Changes to generated files:
https://gist.github.com/BugsNash/595ec7b86ce850d676aa8722f68abbf8/revisions

BUG=494719
Review-Url: https://codereview.chromium.org/2846723003
Cr-Commit-Position: refs/heads/master@{#467909}
Committed: https://chromium.googlesource.com/chromium/src/+/518f93704e475c7d61dbe7d853cdbf3baccb445e

[Bugs Nash, 2017-04-27 04:52:13]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 04:52:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-04-27 05:42:07]

Description was changed from

==========
Removed local RefPtr created from PassRefPtr arg in generated file.

This is a follow up from https://codereview.chromium.org/2807073002

This patch removed a generated instance of a PassRefPtr object being
copied into a RefPtr object.

All instances of PassRefPtr objects being copied into RefPtr objects
need to be wrapped in std::move to avoid introducing ref churn in
future changes when all PassRefPtr objects will be replaced with RefPtr
objects. In this case creating a local RefPtr just to copy the
PassRefPtr argument into, a std::move wrap doesn't make sense as it
would result in a final state where a RefPtr argument is moved into a
local RefPtr for no reason. So to handle this cases I have converted
the PassRefPtr argument to RefPtr in advance, and removed the local
RefPtr argument, instead using the passed RefPtr in the
method.

This patch
- Changed the argument passed from PassRefPtr to RefPtr
- Removed the logic for creating a local RefPtr argument
- Changed the naming logic to name RefPtr arguments as rpParamTypeName
- Removed the self.value variable and used self.name instead, as
  self.value was only used to store the name of the local RefPtr
  variable separate from the PassRefPtr argument
- Removed the comment in the header about PassRefPtr parameters
- Removed the base_name variable in build_param_name as this was
  causing a presubmit error from clashing with the global base_name

BUG=494719
==========

to

==========
Removed local RefPtr created from PassRefPtr arg in generated file.

This is a follow up from https://codereview.chromium.org/2807073002

This patch removed a generated instance of a PassRefPtr object being
copied into a RefPtr object.

All instances of PassRefPtr objects being copied into RefPtr objects
need to be wrapped in std::move to avoid introducing ref churn in
future changes when all PassRefPtr objects will be replaced with RefPtr
objects. In this case creating a local RefPtr just to copy the
PassRefPtr argument into, a std::move wrap doesn't make sense as it
would result in a final state where a RefPtr argument is moved into a
local RefPtr for no reason. So to handle this cases I have converted
the PassRefPtr argument to RefPtr in advance, and removed the local
RefPtr argument, instead using the passed RefPtr in the
method.

This patch
- Changed the argument passed from PassRefPtr to RefPtr
- Removed the logic for creating a local RefPtr argument
- Changed the naming logic to name RefPtr arguments as rpParamTypeName
- Removed the self.value variable and used self.name instead, as
  self.value was only used to store the name of the local RefPtr
  variable separate from the PassRefPtr argument
- Removed the comment in the header about PassRefPtr parameters
- Removed the base_name variable in build_param_name as this was
  causing a presubmit error from clashing with the global base_name

Changes to generated files:
https://gist.github.com/BugsNash/595ec7b86ce850d676aa8722f68abbf8/revisions

BUG=494719
==========

[Bugs Nash, 2017-04-27 05:45:52]

bugsnash@chromium.org changed reviewers:
+ alph@chromium.org, yutak@chromium.org

[Yuta Kitamura, 2017-04-27 06:12:29]

LGTM but I'm not too confident about this file.

[commit-bot: I haz the power, 2017-04-27 06:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 06:42:23]

Dry run: This issue passed the CQ dry run.

[alph, 2017-04-27 22:57:05]

lgtm

https://codereview.chromium.org/2846723003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py
(right):

https://codereview.chromium.org/2846723003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py:158:
self.is_rp = re.match(r"RefPtr<", param_decl) is not None
doesn't seems to be used outside the function.

https://codereview.chromium.org/2846723003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py:160:
self.name = "rp" + self.name[0].upper() + self.name[1:]
In fact, you don't really need to mangle the name anymore. Right?

[Bugs Nash, 2017-04-27 23:05:59]

https://codereview.chromium.org/2846723003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py
(right):

https://codereview.chromium.org/2846723003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py:160:
self.name = "rp" + self.name[0].upper() + self.name[1:]
On 2017/04/27 at 22:57:04, alph wrote:
> In fact, you don't really need to mangle the name anymore. Right?

Nope, I just thought rpInnerTypeName was more readable than paramRefPtr, but the
mangling does make the code more confusing so I'll remove it

[Bugs Nash, 2017-04-27 23:51:04]

Addressed comments.

[Bugs Nash, 2017-04-27 23:57:30]

On 2017/04/27 at 23:51:04, Bugs Nash wrote:
> Addressed comments.

I left the logic inside build_param_name so that the variable would be named
paramInnerType (rather than paramRefPtr) but removed the logic for the rp
prefix.

[Bugs Nash, 2017-04-28 01:37:53]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-04-28 01:37:54]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org,
yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/2846723003/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-04-28 01:39:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 03:29:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:29:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bugs Nash, 2017-04-28 03:43:43]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:44:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 05:49:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493351023145120,
"parent_rev": "322942d036996ccb422964135650d4416081474c", "commit_rev":
"518f93704e475c7d61dbe7d853cdbf3baccb445e"}

[commit-bot: I haz the power, 2017-04-28 05:49:58]

Description was changed from

==========
Removed local RefPtr created from PassRefPtr arg in generated file.

This is a follow up from https://codereview.chromium.org/2807073002

This patch removed a generated instance of a PassRefPtr object being
copied into a RefPtr object.

All instances of PassRefPtr objects being copied into RefPtr objects
need to be wrapped in std::move to avoid introducing ref churn in
future changes when all PassRefPtr objects will be replaced with RefPtr
objects. In this case creating a local RefPtr just to copy the
PassRefPtr argument into, a std::move wrap doesn't make sense as it
would result in a final state where a RefPtr argument is moved into a
local RefPtr for no reason. So to handle this cases I have converted
the PassRefPtr argument to RefPtr in advance, and removed the local
RefPtr argument, instead using the passed RefPtr in the
method.

This patch
- Changed the argument passed from PassRefPtr to RefPtr
- Removed the logic for creating a local RefPtr argument
- Changed the naming logic to name RefPtr arguments as rpParamTypeName
- Removed the self.value variable and used self.name instead, as
  self.value was only used to store the name of the local RefPtr
  variable separate from the PassRefPtr argument
- Removed the comment in the header about PassRefPtr parameters
- Removed the base_name variable in build_param_name as this was
  causing a presubmit error from clashing with the global base_name

Changes to generated files:
https://gist.github.com/BugsNash/595ec7b86ce850d676aa8722f68abbf8/revisions

BUG=494719
==========

to

==========
Removed local RefPtr created from PassRefPtr arg in generated file.

This is a follow up from https://codereview.chromium.org/2807073002

This patch removed a generated instance of a PassRefPtr object being
copied into a RefPtr object.

All instances of PassRefPtr objects being copied into RefPtr objects
need to be wrapped in std::move to avoid introducing ref churn in
future changes when all PassRefPtr objects will be replaced with RefPtr
objects. In this case creating a local RefPtr just to copy the
PassRefPtr argument into, a std::move wrap doesn't make sense as it
would result in a final state where a RefPtr argument is moved into a
local RefPtr for no reason. So to handle this cases I have converted
the PassRefPtr argument to RefPtr in advance, and removed the local
RefPtr argument, instead using the passed RefPtr in the
method.

This patch
- Changed the argument passed from PassRefPtr to RefPtr
- Removed the logic for creating a local RefPtr argument
- Changed the naming logic to name RefPtr arguments as rpParamTypeName
- Removed the self.value variable and used self.name instead, as
  self.value was only used to store the name of the local RefPtr
  variable separate from the PassRefPtr argument
- Removed the comment in the header about PassRefPtr parameters
- Removed the base_name variable in build_param_name as this was
  causing a presubmit error from clashing with the global base_name

Changes to generated files:
https://gist.github.com/BugsNash/595ec7b86ce850d676aa8722f68abbf8/revisions

BUG=494719

Review-Url: https://codereview.chromium.org/2846723003
Cr-Commit-Position: refs/heads/master@{#467909}
Committed:
https://chromium.googlesource.com/chromium/src/+/518f93704e475c7d61dbe7d853cd...
==========

[commit-bot: I haz the power, 2017-04-28 05:49:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/518f93704e475c7d61dbe7d853cd...