third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl - Issue 2846723003: Removed local RefPtr created from PassRefPtr arg in generated file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl

Issue 2846723003: Removed local RefPtr created from PassRefPtr arg in generated file. (Closed)

Patch Set: Addressed comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py ('k') | third_party/WebKit/Source/core/probe/CoreProbes.pidl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl

index 6dd319b62f24c6520f59f4930b84d678cbbae63a..3341b396066f04e88e124f68a15f8845150014ce 100644

--- a/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl

@@ -54,11 +54,6 @@ namespace probe {

{{sink_class}}* sink = To{{sink_class}}({{probe.params[0].name}});

if (!sink)

return;

-{% for param in probe.params %}

-{% if param.is_prp %}

- RefPtr<{{param.inner_type}}> {{param.value}} = {{param.name}};

-{% endif %}

-{% endfor %}

{% for agent in probe.agents %}

{% set class_name = agent | agent_name_to_class %}

if (sink->has{{class_name}}s()) {

@@ -90,7 +85,7 @@ CORE_EXPORT void {{probe.name}}({{ params_list(probe) }}) {

{% call probe_body(probe, "") %}

{%- for param in probe.params %}

{%- if not loop.first or "Keep" in param.options -%}

-{{param.value}}

+{{param.name}}

{%- if not loop.last %}, {% endif -%}

{%- endif -%}

{%- endfor %}