Removed local RefPtr created from PassRefPtr arg in generated file.

third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import ast
 import optparse
 import os.path
 import re
 import sys
 
@@ skipping 137 matching lines @@
         min_type_tokens = 2 if re.match("(const|unsigned long) ", param_decl) else 1
 
         if len(param_decl.split(" ")) > min_type_tokens:
             parts = param_decl.split(" ")
             self.type = " ".join(parts[:-1])
             self.name = parts[-1]
         else:
             self.type = param_decl
             self.name = build_param_name(self.type)
 
-        self.value = self.name
-        self.is_prp = re.match(r"PassRefPtr<", param_decl) is not None
-        if self.is_prp:
-            self.name = "prp" + self.name[0].upper() + self.name[1:]
-            self.inner_type = re.match(r"PassRefPtr<(.+)>", param_decl).group(1)
+        self.is_rp = re.match(r"RefPtr<", param_decl) is not None

[alph, 2017/04/27 22:57:04]

doesn't seems to be used outside the function.

+        if self.is_rp:
+            self.name = "rp" + self.name[0].upper() + self.name[1:]

[alph, 2017/04/27 22:57:04]

In fact, you don't really need to mangle the name anymore. Right?

[Bugs Nash, 2017/04/27 23:05:59]

Nope, I just thought rpInnerTypeName was more readable than paramRefPtr, but the
mangling does make the code more confusing so I'll remove it

 
         if self.type[-1] == "*" and "char" not in self.type:
             self.member_type = "Member<%s>" % self.type[:-1]
         else:
             self.member_type = self.type
 
 
 def build_param_name(param_type):
-    base_name = re.match(r"(const |PassRefPtr<)?(\w*)", param_type).group(2)
-    return "param" + base_name
+    return "param" + re.match(r"(const |RefPtr<)?(\w*)", param_type).group(2)
 
 
 def load_config(file_name):
     default_config = {
         "settings": {},
         "observers": {}
     }
     if not file_name:
         return default_config
     with open(file_name) as config_file:
@@ skipping 76 matching lines @@
 sink_h_file = open(output_dirpath + "/" + to_singular(base_name) + "Sink.h", "w")
 sink_h_file.write(sink_h_template.render(template_context))
 sink_h_file.close()
 
 for f in files:
     template_context["file"] = f
     h_template = jinja_env.get_template("/InstrumentingProbesInl.h.tmpl")
     h_file = open(output_dirpath + "/" + f.header_name + ".h", "w")
     h_file.write(h_template.render(template_context))
     h_file.close()