Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2844183002: Generate StyleBoxData in ComputedStyleBase. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate StyleBoxData in ComputedStyleBase. This patch generates the following fields as part of a group: - width and height ('storage_only' of type Length) - min-width and min-height ('storage_only' of type Length) - max-width and max-height ('storage_only' of type Length) - VerticalAlignLength ('storage_only' of type Length) - z-index ('storage_only' of type int) - HasAutoZIndex ('storage_only' of type bool) - box-sizing ('storage_only' of type EBoxSizing) - box-decoration-break ('storage_only' of type EBoxSizing) A few CSS properties are specified in ComputedStyleExtraFields.json5 rather than CSSProperties.json5: - VerticalAlignLength, since we can't generate unions yet. - box-sizing, will specify in CSSProperties.json5 in a separate patch - box-decoration-break, will specify in CSSProperties.json5 in a separate patch Future patches will also: - Change (/min/max)(width/height) to be external fields so their getters/setters can be generated. - Change box-sizing to be a keyword field so their getters/setters can be generated. - Change box-decoration-break to be a keyword field so their getters/setters can be generated. Diff of generated files: https://gist.github.com/85b78bfcaf9ec0d78ea33eea24a49d9f/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2844183002 Cr-Commit-Position: refs/heads/master@{#471202} Committed: https://chromium.googlesource.com/chromium/src/+/a1ca535f232d0b1910a5041dd6167d6ebe08a0ea

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -59 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 3 4 5 6 7 6 chunks +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 2 3 4 5 6 7 2 chunks +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 4 5 6 7 5 chunks +2 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 51 (45 generated)
shend
Hi Naina, PTAL
3 years, 7 months ago (2017-05-01 23:47:07 UTC) #22
nainar
lgtm
3 years, 7 months ago (2017-05-01 23:54:41 UTC) #23
shend
Hi Eddy, PTAL :)
3 years, 7 months ago (2017-05-02 00:25:20 UTC) #30
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-03 03:28:12 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844183002/130001
3 years, 7 months ago (2017-05-12 02:59:18 UTC) #48
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 03:04:54 UTC) #51
Message was sent while issue was closed.
Committed patchset #8 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/a1ca535f232d0b1910a5041dd616...

Powered by Google App Engine
This is Rietveld 408576698