|
|
DescriptionGenerate StyleBoxData in ComputedStyleBase.
This patch generates the following fields as part of a group:
- width and height ('storage_only' of type Length)
- min-width and min-height ('storage_only' of type Length)
- max-width and max-height ('storage_only' of type Length)
- VerticalAlignLength ('storage_only' of type Length)
- z-index ('storage_only' of type int)
- HasAutoZIndex ('storage_only' of type bool)
- box-sizing ('storage_only' of type EBoxSizing)
- box-decoration-break ('storage_only' of type EBoxSizing)
A few CSS properties are specified in ComputedStyleExtraFields.json5
rather than CSSProperties.json5:
- VerticalAlignLength, since we can't generate unions yet.
- box-sizing, will specify in CSSProperties.json5 in a separate patch
- box-decoration-break, will specify in CSSProperties.json5 in a
separate patch
Future patches will also:
- Change (/min/max)(width/height) to be external fields so their
getters/setters can be generated.
- Change box-sizing to be a keyword field so their getters/setters can
be generated.
- Change box-decoration-break to be a keyword field so their
getters/setters can be generated.
Diff of generated files:
https://gist.github.com/85b78bfcaf9ec0d78ea33eea24a49d9f/revisions
BUG=628043
Review-Url: https://codereview.chromium.org/2844183002
Cr-Commit-Position: refs/heads/master@{#471202}
Committed: https://chromium.googlesource.com/chromium/src/+/a1ca535f232d0b1910a5041dd6167d6ebe08a0ea
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #Patch Set 6 : Rebase #Patch Set 7 : Rebase #Patch Set 8 : Rebase #
Dependent Patchsets: Messages
Total messages: 51 (45 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Generate StyleBoxData in ComputedStyleBase. This patch generates the following fields as part of a group: - width and height ('storage_only' of type Length) - min-width and min-height ('storage_only' of type Length) - max-width and max-height ('storage_only' of type Length) - VerticalAlignLength ('storage_only' of type Length) - z-index ('storage_only' of type int) - HasAutoZIndex ('storage_only' of type bool) - box-sizing ('storage_only' of type EBoxSizing) - box-decoration-break ('storage_only' of type EBoxSizing) A few CSS properties are specified in ComputedStyleExtraFields.json5 rather than CSSProperties.json5: - VerticalAlignLength, since we can't generate unions yet. - box-sizing, will specify in CSSProperties.json5 in a separate patch - box-decoration-break, will specify in CSSProperties.json5 in a separate patch Future patches will also: - Change (/min/max)(width/height) to be external fields so their getters/setters can be generated. - Change box-sizing to be a keyword field so their getters/setters can be generated. - Change box-decoration-break to be a keyword field so their getters/setters can be generated. BUG=628043 ========== to ========== Generate StyleBoxData in ComputedStyleBase. This patch generates the following fields as part of a group: - width and height ('storage_only' of type Length) - min-width and min-height ('storage_only' of type Length) - max-width and max-height ('storage_only' of type Length) - VerticalAlignLength ('storage_only' of type Length) - z-index ('storage_only' of type int) - HasAutoZIndex ('storage_only' of type bool) - box-sizing ('storage_only' of type EBoxSizing) - box-decoration-break ('storage_only' of type EBoxSizing) A few CSS properties are specified in ComputedStyleExtraFields.json5 rather than CSSProperties.json5: - VerticalAlignLength, since we can't generate unions yet. - box-sizing, will specify in CSSProperties.json5 in a separate patch - box-decoration-break, will specify in CSSProperties.json5 in a separate patch Future patches will also: - Change (/min/max)(width/height) to be external fields so their getters/setters can be generated. - Change box-sizing to be a keyword field so their getters/setters can be generated. - Change box-decoration-break to be a keyword field so their getters/setters can be generated. Diff of generated files: https://gist.github.com/darrnshn/344167db95c79d9690643aa0dace821b/revisions BUG=628043 ==========
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Generate StyleBoxData in ComputedStyleBase. This patch generates the following fields as part of a group: - width and height ('storage_only' of type Length) - min-width and min-height ('storage_only' of type Length) - max-width and max-height ('storage_only' of type Length) - VerticalAlignLength ('storage_only' of type Length) - z-index ('storage_only' of type int) - HasAutoZIndex ('storage_only' of type bool) - box-sizing ('storage_only' of type EBoxSizing) - box-decoration-break ('storage_only' of type EBoxSizing) A few CSS properties are specified in ComputedStyleExtraFields.json5 rather than CSSProperties.json5: - VerticalAlignLength, since we can't generate unions yet. - box-sizing, will specify in CSSProperties.json5 in a separate patch - box-decoration-break, will specify in CSSProperties.json5 in a separate patch Future patches will also: - Change (/min/max)(width/height) to be external fields so their getters/setters can be generated. - Change box-sizing to be a keyword field so their getters/setters can be generated. - Change box-decoration-break to be a keyword field so their getters/setters can be generated. Diff of generated files: https://gist.github.com/darrnshn/344167db95c79d9690643aa0dace821b/revisions BUG=628043 ========== to ========== Generate StyleBoxData in ComputedStyleBase. This patch generates the following fields as part of a group: - width and height ('storage_only' of type Length) - min-width and min-height ('storage_only' of type Length) - max-width and max-height ('storage_only' of type Length) - VerticalAlignLength ('storage_only' of type Length) - z-index ('storage_only' of type int) - HasAutoZIndex ('storage_only' of type bool) - box-sizing ('storage_only' of type EBoxSizing) - box-decoration-break ('storage_only' of type EBoxSizing) A few CSS properties are specified in ComputedStyleExtraFields.json5 rather than CSSProperties.json5: - VerticalAlignLength, since we can't generate unions yet. - box-sizing, will specify in CSSProperties.json5 in a separate patch - box-decoration-break, will specify in CSSProperties.json5 in a separate patch Future patches will also: - Change (/min/max)(width/height) to be external fields so their getters/setters can be generated. - Change box-sizing to be a keyword field so their getters/setters can be generated. - Change box-decoration-break to be a keyword field so their getters/setters can be generated. Diff of generated files: https://gist.github.com/darrnshn/800a03616219914268bc24bbf8914265/revisions BUG=628043 ==========
shend@chromium.org changed reviewers: + nainar@chromium.org
Hi Naina, PTAL
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Description was changed from ========== Generate StyleBoxData in ComputedStyleBase. This patch generates the following fields as part of a group: - width and height ('storage_only' of type Length) - min-width and min-height ('storage_only' of type Length) - max-width and max-height ('storage_only' of type Length) - VerticalAlignLength ('storage_only' of type Length) - z-index ('storage_only' of type int) - HasAutoZIndex ('storage_only' of type bool) - box-sizing ('storage_only' of type EBoxSizing) - box-decoration-break ('storage_only' of type EBoxSizing) A few CSS properties are specified in ComputedStyleExtraFields.json5 rather than CSSProperties.json5: - VerticalAlignLength, since we can't generate unions yet. - box-sizing, will specify in CSSProperties.json5 in a separate patch - box-decoration-break, will specify in CSSProperties.json5 in a separate patch Future patches will also: - Change (/min/max)(width/height) to be external fields so their getters/setters can be generated. - Change box-sizing to be a keyword field so their getters/setters can be generated. - Change box-decoration-break to be a keyword field so their getters/setters can be generated. Diff of generated files: https://gist.github.com/darrnshn/800a03616219914268bc24bbf8914265/revisions BUG=628043 ========== to ========== Generate StyleBoxData in ComputedStyleBase. This patch generates the following fields as part of a group: - width and height ('storage_only' of type Length) - min-width and min-height ('storage_only' of type Length) - max-width and max-height ('storage_only' of type Length) - VerticalAlignLength ('storage_only' of type Length) - z-index ('storage_only' of type int) - HasAutoZIndex ('storage_only' of type bool) - box-sizing ('storage_only' of type EBoxSizing) - box-decoration-break ('storage_only' of type EBoxSizing) A few CSS properties are specified in ComputedStyleExtraFields.json5 rather than CSSProperties.json5: - VerticalAlignLength, since we can't generate unions yet. - box-sizing, will specify in CSSProperties.json5 in a separate patch - box-decoration-break, will specify in CSSProperties.json5 in a separate patch Future patches will also: - Change (/min/max)(width/height) to be external fields so their getters/setters can be generated. - Change box-sizing to be a keyword field so their getters/setters can be generated. - Change box-decoration-break to be a keyword field so their getters/setters can be generated. Diff of generated files: https://gist.github.com/85b78bfcaf9ec0d78ea33eea24a49d9f/revisions BUG=628043 ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
shend@chromium.org changed reviewers: + meade@chromium.org
Hi Eddy, PTAL :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org, meade@chromium.org Link to the patchset: https://codereview.chromium.org/2844183002/#ps130001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 130001, "attempt_start_ts": 1494557930032890, "parent_rev": "15ce2350e162a019bc8735c14a8a9a70cb42dba8", "commit_rev": "a1ca535f232d0b1910a5041dd6167d6ebe08a0ea"}
Message was sent while issue was closed.
Description was changed from ========== Generate StyleBoxData in ComputedStyleBase. This patch generates the following fields as part of a group: - width and height ('storage_only' of type Length) - min-width and min-height ('storage_only' of type Length) - max-width and max-height ('storage_only' of type Length) - VerticalAlignLength ('storage_only' of type Length) - z-index ('storage_only' of type int) - HasAutoZIndex ('storage_only' of type bool) - box-sizing ('storage_only' of type EBoxSizing) - box-decoration-break ('storage_only' of type EBoxSizing) A few CSS properties are specified in ComputedStyleExtraFields.json5 rather than CSSProperties.json5: - VerticalAlignLength, since we can't generate unions yet. - box-sizing, will specify in CSSProperties.json5 in a separate patch - box-decoration-break, will specify in CSSProperties.json5 in a separate patch Future patches will also: - Change (/min/max)(width/height) to be external fields so their getters/setters can be generated. - Change box-sizing to be a keyword field so their getters/setters can be generated. - Change box-decoration-break to be a keyword field so their getters/setters can be generated. Diff of generated files: https://gist.github.com/85b78bfcaf9ec0d78ea33eea24a49d9f/revisions BUG=628043 ========== to ========== Generate StyleBoxData in ComputedStyleBase. This patch generates the following fields as part of a group: - width and height ('storage_only' of type Length) - min-width and min-height ('storage_only' of type Length) - max-width and max-height ('storage_only' of type Length) - VerticalAlignLength ('storage_only' of type Length) - z-index ('storage_only' of type int) - HasAutoZIndex ('storage_only' of type bool) - box-sizing ('storage_only' of type EBoxSizing) - box-decoration-break ('storage_only' of type EBoxSizing) A few CSS properties are specified in ComputedStyleExtraFields.json5 rather than CSSProperties.json5: - VerticalAlignLength, since we can't generate unions yet. - box-sizing, will specify in CSSProperties.json5 in a separate patch - box-decoration-break, will specify in CSSProperties.json5 in a separate patch Future patches will also: - Change (/min/max)(width/height) to be external fields so their getters/setters can be generated. - Change box-sizing to be a keyword field so their getters/setters can be generated. - Change box-decoration-break to be a keyword field so their getters/setters can be generated. Diff of generated files: https://gist.github.com/85b78bfcaf9ec0d78ea33eea24a49d9f/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2844183002 Cr-Commit-Position: refs/heads/master@{#471202} Committed: https://chromium.googlesource.com/chromium/src/+/a1ca535f232d0b1910a5041dd616... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:130001) as https://chromium.googlesource.com/chromium/src/+/a1ca535f232d0b1910a5041dd616... |