Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2845523004:
[recipes.py] refactor loading for operational_arguments. (Closed)
|
Created:
3 years, 8 months ago by iannucci Modified:
3 years, 7 months ago CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org Target Ref:
refs/heads/master Project:
recipe_engine Visibility:
Public. |
Description[recipes.py] refactor loading for operational_arguments.
R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2845523004
Committed: https://github.com/luci/recipes-py/commit/8b7295c5344ed0cb6ed7843f9df2c6b58a015fe5
Patch Set 1 #
Total comments: 2
Patch Set 2 : improve type, set default #
Depends on Patchset: Messages
Total messages: 18 (12 generated)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/35c493917c349f10)
lgtm w/ nit nit is silly but I thought you might be interested. Feel free to ignore. https://codereview.chromium.org/2845523004/diff/1/recipes.py File recipes.py (right): https://codereview.chromium.org/2845523004/diff/1/recipes.py#newcode390 recipes.py:390: with open(value) as fd: nit: Up to you, but if you care you could make this more optimal with: with open(value) as fd: data = json.load(fd) jsonpb.ParseDict(data, op_args) return op_args This would load JSON from stream instead of full memory buffer. But whatever.
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2845523004/diff/1/recipes.py File recipes.py (right): https://codereview.chromium.org/2845523004/diff/1/recipes.py#newcode390 recipes.py:390: with open(value) as fd: On 2017/04/26 19:52:04, dnj wrote: > nit: Up to you, but if you care you could make this more optimal with: > > with open(value) as fd: > data = json.load(fd) > jsonpb.ParseDict(data, op_args) > return op_args > > This would load JSON from stream instead of full memory buffer. But whatever. oh, yeah I just transplanted this code without looking at it too much, this is a good improvement. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by iannucci@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org Link to the patchset: https://codereview.chromium.org/2845523004/#ps20001 (title: "improve type, set default")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493245818963450,
"parent_rev": "ce0d4e67ec52fcf2aa662635e110a5427aaa4a09", "commit_rev":
"8b7295c5344ed0cb6ed7843f9df2c6b58a015fe5"}
Message was sent while issue was closed.
Description was changed from ========== [recipes.py] refactor loading for operational_arguments. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= ========== to ========== [recipes.py] refactor loading for operational_arguments. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= Review-Url: https://codereview.chromium.org/2845523004 Committed: https://github.com/luci/recipes-py/commit/8b7295c5344ed0cb6ed7843f9df2c6b58a0... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://github.com/luci/recipes-py/commit/8b7295c5344ed0cb6ed7843f9df2c6b58a0...
Message was sent while issue was closed.
On 2017/04/26 22:34:18, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as > https://github.com/luci/recipes-py/commit/8b7295c5344ed0cb6ed7843f9df2c6b58a0... Did this CL break presubmit? I just saw this pre-submit failure that seems possibly related to this CL: https://codereview.chromium.org/2835943003 The failure looked similar to this (now reverted) patch: https://codereview.chromium.org/2833723003 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
