[recipes.py] refactor common argument parsing, directly validate --package

[recipes.py] refactor common argument parsing, directly validate --package

R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2840283002
Committed: https://github.com/luci/recipes-py/commit/f162918ed7c917f187c8098b88e4fd02b82e06aa

[iannucci, 2017-04-26 18:28:30]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:28:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 18:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 18:33:32]

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/35c4574de51d7e10)

[iannucci, 2017-04-26 18:50:22]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:50:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 18:54:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 18:54:06]

Dry run: This issue passed the CQ dry run.

[dnj, 2017-04-26 21:08:15]

https://codereview.chromium.org/2840283002/diff/20001/recipes.py
File recipes.py (right):

https://codereview.chromium.org/2840283002/diff/20001/recipes.py#newcode347
recipes.py:347: def add_common_args(parser):
Not appreciating why this is pulled out into a separate function. Is something
else ever going to call it? If not, I'd prefer it just be part of the rest of
the parser setup.

https://codereview.chromium.org/2840283002/diff/20001/recipes.py#newcode395
recipes.py:395: if args.command == "remote":
Same here - why not just put this content at the call site. No need to split
this up.

[dnj, 2017-04-26 21:13:12]

Answered offline, this is just the beginning of a split-up. lgtm

[iannucci, 2017-04-26 21:53:17]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-04-26 21:53:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://codereview.chromium.org/2840283002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-26 21:53:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 21:56:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493243597831750,
"parent_rev": "77da3ca06f0c46b613b51eea0cf2186c7e8b58c9", "commit_rev":
"f162918ed7c917f187c8098b88e4fd02b82e06aa"}

[commit-bot: I haz the power, 2017-04-26 21:56:39]

Description was changed from

==========
[recipes.py] refactor common argument parsing, directly validate --package

R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=
==========

to

==========
[recipes.py] refactor common argument parsing, directly validate --package

R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2840283002
Committed:
https://github.com/luci/recipes-py/commit/f162918ed7c917f187c8098b88e4fd02b82...
==========

[commit-bot: I haz the power, 2017-04-26 21:56:39]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/f162918ed7c917f187c8098b88e4fd02b82...