Remove unneeded enum forward declarations

Remove unneeded enum forward declarations

Forward declaring of enums without specifying a type is illegal. These
forward declarations only worked because they weren't needed. They were
found by VC++'s overzealous C4471 warning.

R=raymes@chromium.org

Review-Url: https://codereview.chromium.org/2835943003
Cr-Commit-Position: refs/heads/master@{#467734}
Committed: https://chromium.googlesource.com/chromium/src/+/9d3356ba7d351bbb94a3eb25d80f052212fdcb1b

[brucedawson, 2017-04-24 20:26:47]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 20:27:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 21:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 21:27:47]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-04-24 21:34:58]

On 2017/04/24 21:27:47, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Simple code cleanup. PTAL.

[brucedawson, 2017-04-24 21:51:39]

Description was changed from

==========
Remove unneeded enum forward declares

Forward declaring of enums without specifying a type is illegal. These
forward declarations only worked because they weren't needed. They were
found by VC++'s overzealous C4471 warning.

R=raymes@chromium.org
==========

to

==========
Remove unneeded enum forward declarations

Forward declaring of enums without specifying a type is illegal. These
forward declarations only worked because they weren't needed. They were
found by VC++'s overzealous C4471 warning.

R=raymes@chromium.org
==========

[dmazzoni, 2017-04-25 07:14:53]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-04-25 07:14:53]

lgtm

[brucedawson, 2017-04-25 17:01:55]

On 2017/04/25 07:14:53, dmazzoni wrote:
> lgtm

Thanks. Still need approval for download_target_determiner.h,
pepper_tcp_socket_message_filter.h, and webmediaplayer_ms.h.

[DaleCurtis, 2017-04-25 17:04:26]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2017-04-25 17:04:26]

media/ lgtm (note, no media OWNER added, just saw this on the mailing list)

[brucedawson, 2017-04-25 17:32:07]

On 2017/04/25 17:04:26, DaleCurtis wrote:
> media/ lgtm (note, no media OWNER added, just saw this on the mailing list)

Ah - my mistake. I thought raymes@ had coverage for the entire thing, but I must
have mis-read the "git cl owners" output.

raymes@ - can you review
content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h
asanka@ - can you review chrome/browser/download/download_target_determiner.h

[raymes, 2017-04-25 22:05:31]

On 2017/04/25 17:32:07, brucedawson wrote:
> On 2017/04/25 17:04:26, DaleCurtis wrote:
> > media/ lgtm (note, no media OWNER added, just saw this on the mailing list)
> 
> Ah - my mistake. I thought raymes@ had coverage for the entire thing, but I
must
> have mis-read the "git cl owners" output.
> 
> raymes@ - can you review
> content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h
> asanka@ - can you review chrome/browser/download/download_target_determiner.h

pepper lgtm

[asanka, 2017-04-26 21:29:22]

asanka@chromium.org changed reviewers:
+ asanka@chromium.org

[asanka, 2017-04-26 21:29:23]

lgtm

[brucedawson, 2017-04-26 21:30:58]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-04-26 21:32:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 21:44:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 21:44:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brucedawson, 2017-04-27 16:35:24]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-04-27 16:35:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 17:55:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493310924869020, "parent_rev":
"a8786d03dcf223dd01b3459b5566bfed41beb2ba", "commit_rev":
"9d3356ba7d351bbb94a3eb25d80f052212fdcb1b"}

[commit-bot: I haz the power, 2017-04-27 17:55:36]

Description was changed from

==========
Remove unneeded enum forward declarations

Forward declaring of enums without specifying a type is illegal. These
forward declarations only worked because they weren't needed. They were
found by VC++'s overzealous C4471 warning.

R=raymes@chromium.org
==========

to

==========
Remove unneeded enum forward declarations

Forward declaring of enums without specifying a type is illegal. These
forward declarations only worked because they weren't needed. They were
found by VC++'s overzealous C4471 warning.

R=raymes@chromium.org

Review-Url: https://codereview.chromium.org/2835943003
Cr-Commit-Position: refs/heads/master@{#467734}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d3356ba7d351bbb94a3eb25d80f...
==========

[commit-bot: I haz the power, 2017-04-27 17:55:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d3356ba7d351bbb94a3eb25d80f...