3 years, 8 months ago
(2017-04-26 19:18:32 UTC)
#4
Kyle Horimoto
LGTM I don't think that keeping a raw pointer is an issue at all. We ...
3 years, 8 months ago
(2017-04-26 21:12:50 UTC)
#5
LGTM
I don't think that keeping a raw pointer is an issue at all. We only will ever
create one factory instance (per process), so the amount of memory allocated is
O(1). Once the process is killed, the heap is cleared, so that object will be
destroyed.
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago
(2017-04-26 21:19:06 UTC)
#6
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1493244529495700, "parent_rev": "789b5e528fb3bd9ca44341de46547c45355652ab", "commit_rev": "40efa1fd583885791e551dfcf1374f6925e1df6c"}
3 years, 8 months ago
(2017-04-26 22:15:04 UTC)
#10
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493244529495700, "parent_rev":
"789b5e528fb3bd9ca44341de46547c45355652ab", "commit_rev":
"40efa1fd583885791e551dfcf1374f6925e1df6c"}
commit-bot: I haz the power
Description was changed from ========== [ProximityAuth] Remote static initializers from uWeave classes. Keeping a raw ...
3 years, 8 months ago
(2017-04-26 22:15:15 UTC)
#11
Message was sent while issue was closed.
Description was changed from
==========
[ProximityAuth] Remote static initializers from uWeave classes.
Keeping a raw pointer around isn't that ideal, as it leaks memory, but the
alternative of refactoring all classes to take a factory in the constructor is a
lot more work.
==========
to
==========
[ProximityAuth] Remote static initializers from uWeave classes.
Keeping a raw pointer around isn't that ideal, as it leaks memory, but the
alternative of refactoring all classes to take a factory in the constructor is a
lot more work.
Review-Url: https://codereview.chromium.org/2844773002
Cr-Commit-Position: refs/heads/master@{#467480}
Committed:
https://chromium.googlesource.com/chromium/src/+/40efa1fd583885791e551dfcf137...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/40efa1fd583885791e551dfcf1374f6925e1df6c
3 years, 8 months ago
(2017-04-26 22:15:16 UTC)
#12
Issue 2844773002: [ProximityAuth] Remote static initializers from uWeave classes.
(Closed)
Created 3 years, 8 months ago by Tim Song
Modified 3 years, 8 months ago
Reviewers: Kyle Horimoto
Base URL:
Comments: 0