Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2844773002: [ProximityAuth] Remote static initializers from uWeave classes. (Closed)

Created:
3 years, 8 months ago by Tim Song
Modified:
3 years, 8 months ago
Reviewers:
Kyle Horimoto
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ProximityAuth] Remote static initializers from uWeave classes. Keeping a raw pointer around isn't that ideal, as it leaks memory, but the alternative of refactoring all classes to take a factory in the constructor is a lot more work. Review-Url: https://codereview.chromium.org/2844773002 Cr-Commit-Position: refs/heads/master@{#467480} Committed: https://chromium.googlesource.com/chromium/src/+/40efa1fd583885791e551dfcf1374f6925e1df6c

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
Tim Song
3 years, 8 months ago (2017-04-26 19:18:32 UTC) #4
Kyle Horimoto
LGTM I don't think that keeping a raw pointer is an issue at all. We ...
3 years, 8 months ago (2017-04-26 21:12:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844773002/1
3 years, 8 months ago (2017-04-26 22:09:40 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 22:15:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40efa1fd583885791e551dfcf137...

Powered by Google App Engine
This is Rietveld 408576698