components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc - Issue 2844773002: [ProximityAuth] Remote static initializers from uWeave classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc

Issue 2844773002: [ProximityAuth] Remote static initializers from uWeave classes. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc ('k') | components/cryptauth/ble/bluetooth_low_energy_weave_packet_generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc

diff --git a/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc b/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc

index 2c7601dd513a0d75866e9f13b79a7f43704553f3..a53a139e61d39d0bd6c778f4e7e7455f223b495c 100644

--- a/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc

+++ b/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc

@@ -369,9 +369,9 @@ class CryptAuthBluetoothLowEnergyWeaveClientConnectionTest

receiver_factory_(

new MockBluetoothLowEnergyWeavePacketReceiverFactory()) {

BluetoothLowEnergyWeavePacketGenerator::Factory::SetInstanceForTesting(

- generator_factory_);

+ generator_factory_.get());

BluetoothLowEnergyWeavePacketReceiver::Factory::SetInstanceForTesting(

- receiver_factory_);

+ receiver_factory_.get());

}

~CryptAuthBluetoothLowEnergyWeaveClientConnectionTest() override {

@@ -614,9 +614,9 @@ class CryptAuthBluetoothLowEnergyWeaveClientConnectionTest

scoped_refptr<base::TestSimpleTaskRunner> task_runner_;

base::MessageLoop message_loop_;

bool last_wire_message_success_;

- std::shared_ptr<MockBluetoothLowEnergyWeavePacketGeneratorFactory>

+ std::unique_ptr<MockBluetoothLowEnergyWeavePacketGeneratorFactory>

generator_factory_;

- std::shared_ptr<MockBluetoothLowEnergyWeavePacketReceiverFactory>

+ std::unique_ptr<MockBluetoothLowEnergyWeavePacketReceiverFactory>

receiver_factory_;

MockConnectionObserver connection_observer_;