components/cryptauth/ble/bluetooth_low_energy_weave_packet_generator.h - Issue 2844773002: [ProximityAuth] Remote static initializers from uWeave classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cryptauth/ble/bluetooth_low_energy_weave_packet_generator.h

Issue 2844773002: [ProximityAuth] Remote static initializers from uWeave classes. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc ('k') | components/cryptauth/ble/bluetooth_low_energy_weave_packet_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cryptauth/ble/bluetooth_low_energy_weave_packet_generator.h

diff --git a/components/cryptauth/ble/bluetooth_low_energy_weave_packet_generator.h b/components/cryptauth/ble/bluetooth_low_energy_weave_packet_generator.h

index b59cfa43187ec6ab4dae518c288a47f7569d5203..2cee2b8f16484d35742ebfdc93471996bc084559 100644

--- a/components/cryptauth/ble/bluetooth_low_energy_weave_packet_generator.h

+++ b/components/cryptauth/ble/bluetooth_low_energy_weave_packet_generator.h

@@ -27,7 +27,7 @@ class BluetoothLowEnergyWeavePacketGenerator {

NewInstance();

// Exposed for testing.

- static void SetInstanceForTesting(std::shared_ptr<Factory> factory);

+ static void SetInstanceForTesting(Factory* factory);

protected:

// Exposed for testing.

@@ -35,7 +35,7 @@ class BluetoothLowEnergyWeavePacketGenerator {

BuildInstance();

private:

- static std::shared_ptr<Factory> factory_instance_;

+ static Factory* factory_instance_;

};

virtual Packet CreateConnectionRequest();