Passthrough CmdDecoder: Reset unpack state on some TexImage

Passthrough CmdDecoder: Reset unpack state on some TexImage

The command buffer client handles all the unpack parameters but
alignment for non-compressed texture uploads from client data.
Resetting the unpack state was handled transparently on the
service-side. This implements the resetting in the passthrough cmd
decoder too.

This makes the following tests pass with the passthrough command buffer:
 - conformance2/textures/misc/tex-unpack-params
 - deqp/functional/gles3/texturespecification/teximage2d_unpack_params
 - deqp/functional/gles3/texturespecification/teximage3d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage2d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage3d_unpack_params

BUG=chromium:602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2844393004
Cr-Commit-Position: refs/heads/master@{#468322}
Committed: https://chromium.googlesource.com/chromium/src/+/7ad7f6d7a7478d21b30a505dd00e473a609b687d

[Corentin Wallez, 2017-04-28 21:32:16]

Description was changed from

==========
Passthrough CmdDecoder: Reset unpack state on some TexImage

The command buffer client handles all the unpack parameters but
alignment for non-compressed texture uploads from client data.
Resetting the unpack state was handled transparently on the
service-side. This implements the resetting in the passthrough cmd
decoder too.

BUG=chromium:602688
==========

to

==========
Passthrough CmdDecoder: Reset unpack state on some TexImage

The command buffer client handles all the unpack parameters but
alignment for non-compressed texture uploads from client data.
Resetting the unpack state was handled transparently on the
service-side. This implements the resetting in the passthrough cmd
decoder too.

BUG=chromium:602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2017-04-28 21:35:21]

cwallez@chromium.org changed reviewers:
+ geofflang@chromium.org, kbr@chromium.org

[Corentin Wallez, 2017-04-28 21:35:21]

PTAL

I investigated making the gles2_implementation or WebGLRenderingContextBase send
the unpack reset commands, but it would have required a pretty large refactor of
how TexImage is handled in gles2_implementation. So I put the unpack reset in
the passthrough service instead.

[Corentin Wallez, 2017-04-28 21:35:26]

The CQ bit was checked by cwallez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 21:35:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2017-04-28 21:47:46]

kbr@chromium.org changed reviewers:
+ jbauman@chromium.org, piman@chromium.org

[Ken Russell (switch to Gerrit), 2017-04-28 21:47:46]

This LGTM overall but I'm not an owner. CC'ing piman and jbauman.

Can you point to either a more specific bug or a test that's currently failing
and begins to pass with this CL? That will help with future code understanding.
Thanks.

[commit-bot: I haz the power, 2017-04-29 01:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 01:10:01]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jbauman, 2017-04-29 01:54:56]

lgtm

[Geoff Lang, 2017-05-01 14:37:14]

lgtm

[Corentin Wallez, 2017-05-01 15:19:40]

Description was changed from

==========
Passthrough CmdDecoder: Reset unpack state on some TexImage

The command buffer client handles all the unpack parameters but
alignment for non-compressed texture uploads from client data.
Resetting the unpack state was handled transparently on the
service-side. This implements the resetting in the passthrough cmd
decoder too.

BUG=chromium:602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Passthrough CmdDecoder: Reset unpack state on some TexImage

The command buffer client handles all the unpack parameters but
alignment for non-compressed texture uploads from client data.
Resetting the unpack state was handled transparently on the
service-side. This implements the resetting in the passthrough cmd
decoder too.

This makes the following tests pass with the passthrough command buffer:
 - conformance2/textures/misc/tex-unpack-params
 - deqp/functional/gles3/texturespecification/teximage2d_unpack_params
 - deqp/functional/gles3/texturespecification/teximage3d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage2d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage3d_unpack_params

BUG=chromium:602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2017-05-01 15:20:04]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2017-05-01 15:20:04]

Thanks all for the reviews, and sorry for the wrong OWNERS assignment.

[commit-bot: I haz the power, 2017-05-01 15:20:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 16:22:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493652004434490, "parent_rev":
"7938b191e4a1bae161445ab33dd664a1afa799b7", "commit_rev":
"7ad7f6d7a7478d21b30a505dd00e473a609b687d"}

[commit-bot: I haz the power, 2017-05-01 16:23:18]

Description was changed from

==========
Passthrough CmdDecoder: Reset unpack state on some TexImage

The command buffer client handles all the unpack parameters but
alignment for non-compressed texture uploads from client data.
Resetting the unpack state was handled transparently on the
service-side. This implements the resetting in the passthrough cmd
decoder too.

This makes the following tests pass with the passthrough command buffer:
 - conformance2/textures/misc/tex-unpack-params
 - deqp/functional/gles3/texturespecification/teximage2d_unpack_params
 - deqp/functional/gles3/texturespecification/teximage3d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage2d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage3d_unpack_params

BUG=chromium:602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Passthrough CmdDecoder: Reset unpack state on some TexImage

The command buffer client handles all the unpack parameters but
alignment for non-compressed texture uploads from client data.
Resetting the unpack state was handled transparently on the
service-side. This implements the resetting in the passthrough cmd
decoder too.

This makes the following tests pass with the passthrough command buffer:
 - conformance2/textures/misc/tex-unpack-params
 - deqp/functional/gles3/texturespecification/teximage2d_unpack_params
 - deqp/functional/gles3/texturespecification/teximage3d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage2d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage3d_unpack_params

BUG=chromium:602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2844393004
Cr-Commit-Position: refs/heads/master@{#468322}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ad7f6d7a7478d21b30a505dd00e...
==========

[commit-bot: I haz the power, 2017-05-01 16:23:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7ad7f6d7a7478d21b30a505dd00e...